1338553 - Build bustage: widget/windows/WinUtils.cpp(1830): error C3861: 'SHGetKnownFolderPath': identifier not found

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Honza Bambas (:mayhemer)]

Nearly clean .mozconfig, no local patches, clobbered build.

Debug, win32, on win10, sdk 8.1, vs'15.

Comment 1

[Emanuel Hoogeveen [:ehoogeveen]]

Attachment: Fix missing include in WinUtils.

Looks like this is just missing an include. From [1] we need shlobj.h here; this patch fixes it for me locally.

[1] https://msdn.microsoft.com/en-us/library/windows/desktop/bb762188.aspx

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 8836164 [details] [diff] [review]
Fix missing include in WinUtils.

Review of attachment 8836164 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 3

[Emanuel Hoogeveen [:ehoogeveen]]

This clearly isn't showing up in automation, so I don't think a try run is going to do any good. I did include this patch in a build-only try run for another bug and didn't see any bustage.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/367692beef13
Fix missing include in WinUtils. r=m_kato

Comment 5

[Bill Gianopoulos [:WG9s]]

(In reply to Emanuel Hoogeveen [:ehoogeveen] from comment #3)
> This clearly isn't showing up in automation, so I don't think a try run is
> going to do any good. I did include this patch in a build-only try run for
> another bug and didn't see any bustage.

It might be interesting to figure out why it does not show up in automation.

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/367692beef13