Closed Bug 1338559 Opened 3 years ago Closed 3 years ago

De-recursify 'make check'

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: mshal, Assigned: mshal)

Details

Attachments

(1 file, 1 obsolete file)

As we continue to move more and more things out of 'make check', the time to walk through all the directories starts to be the long pole. I think we can turn this into something similar to HAS_MISC_RULE and just iterate directly through the few directories that remain to get a quick speed win.

If we end up removing all tests out of 'make check', this will end up going away.
If nothing else this will provide us a handy list of all the things we need to get rid of!
Why not do like "tools" rather than "misc"?
(In reply to Mike Hommey [:glandium] from comment #4)
> Why not do like "tools" rather than "misc"?

Oh, I wasn't aware of that. That looks like it should be easier.
Attachment #8836145 - Flags: review?(ted)
Attachment #8836146 - Flags: review?(ted)
Attachment #8836145 - Attachment is obsolete: true
Comment on attachment 8836146 [details]
Bug 1338559 - Use the tier system to recurse for 'make check';

https://reviewboard.mozilla.org/r/111588/#review113990

::: python/mozbuild/mozbuild/backend/recursivemake.py:854
(Diff revision 2)
>                  obj.config = bf.environment
>                  self._create_makefile(obj, stub=stub)
>                  with open(obj.output_path) as fh:
>                      content = fh.read()
>                      # Skip every directory but those with a Makefile
>                      # containing a tools target, or XPI_PKGNAME or

Please update this comment.
Attachment #8836146 - Flags: review?(mh+mozilla) → review+
(In reply to Mike Hommey [:glandium] from comment #7)
> >                      # Skip every directory but those with a Makefile
> >                      # containing a tools target, or XPI_PKGNAME or
> 
> Please update this comment.

I clarified this comment and added another one above the _no_skip('check') line. I didn't add 'check' to this comment since the for loop is specific to the tools tier.
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d0f4a83212fc
Use the tier system to recurse for 'make check'; r=glandium
https://hg.mozilla.org/mozilla-central/rev/d0f4a83212fc
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.