1338559 - De-recursify 'make check'

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

As we continue to move more and more things out of 'make check', the time to walk through all the directories starts to be the long pole. I think we can turn this into something similar to HAS_MISC_RULE and just iterate directly through the few directories that remain to get a quick speed win.

If we end up removing all tests out of 'make check', this will end up going away.

Comment 1

[(not currently active) Ted Mielczarek]

If nothing else this will provide us a handy list of all the things we need to get rid of!

Comment 2

[Michael Shal [:mshal]]

Attachment: Bug 1338559 - Add HAS_CHECK_RULE flag in moz.build;

Review commit: https://reviewboard.mozilla.org/r/111586/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111586/

Comment 3

[Michael Shal [:mshal]]

Attachment: Bug 1338559 - Use the tier system to recurse for 'make check';

This helps us avoid recursing over every directory when we only need to
run 'make check' in a select few.

Review commit: https://reviewboard.mozilla.org/r/111588/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111588/

Comment 4

[Mike Hommey [:glandium]]

Why not do like "tools" rather than "misc"?

Comment 5

[Michael Shal [:mshal]]

(In reply to Mike Hommey [:glandium] from comment #4)
> Why not do like "tools" rather than "misc"?

Oh, I wasn't aware of that. That looks like it should be easier.

Comment 6

[Michael Shal [:mshal]]

Comment on attachment 8836146 [details]
Bug 1338559 - Use the tier system to recurse for 'make check';

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/111588/diff/1-2/

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8836146 [details]
Bug 1338559 - Use the tier system to recurse for 'make check';

https://reviewboard.mozilla.org/r/111588/#review113990

::: python/mozbuild/mozbuild/backend/recursivemake.py:854
(Diff revision 2)
>                  obj.config = bf.environment
>                  self._create_makefile(obj, stub=stub)
>                  with open(obj.output_path) as fh:
>                      content = fh.read()
>                      # Skip every directory but those with a Makefile
>                      # containing a tools target, or XPI_PKGNAME or

Please update this comment.

Comment 8

[Michael Shal [:mshal]]

Comment on attachment 8836146 [details]
Bug 1338559 - Use the tier system to recurse for 'make check';

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/111588/diff/2-3/

Comment 9

[Michael Shal [:mshal]]

(In reply to Mike Hommey [:glandium] from comment #7)
> >                      # Skip every directory but those with a Makefile
> >                      # containing a tools target, or XPI_PKGNAME or
> 
> Please update this comment.

I clarified this comment and added another one above the _no_skip('check') line. I didn't add 'check' to this comment since the for loop is specific to the tools tier.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0f4a83212fc
Use the tier system to recurse for 'make check'; r=glandium

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d0f4a83212fc