Closed Bug 1338592 Opened 4 years ago Closed 4 years ago

Use .nested, not .nestedRange on Protocol

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

The parser always sets the first value of the tuple .nestedRange to NOT_NESTED, so there's no need to actually store it. Instead, we create a range when we're creating the ProtocolType. This makes it clearer what is happening. The range is needed for the type because the nesting pair is compared with those from messages, where the first element can be something else.

Prior to bug 1306708, the lower range could be specified in the IPDL file, but all uses were NOT_NESTED, so I suppose that is why it was eliminated.

Note that the constructor for Protocol sets .nested to NOT_NESTED, but prior to my patch, the field was never used. The constructor also never initialized .nestedRange, but the parser always sets it so that isn't much of an issue.
Comment on attachment 8836141 [details]
Bug 1338592 - Use .nested, not .nestedRange on Protocol.

https://reviewboard.mozilla.org/r/111582/#review114276
Attachment #8836141 - Flags: review?(wmccloskey) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/699380af7093
Use .nested, not .nestedRange on Protocol. r=billm
https://hg.mozilla.org/mozilla-central/rev/699380af7093
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.