Add more basic IPDL tests

RESOLVED FIXED in Firefox 54

Status

()

Core
IPC
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
I noticed a couple of omissions from the unit tests when working on the type checker for the Rust IPDL compiler. First, redeclaration is not allowed even if the initial declaration was from a different frame of the scope. (I initially was not checking correctly this in the Rust IPDL checker.)

Secondly, this adds a few basic tests to ensure that the various Endpoint<> declarations are made. I check three cases: in the same file as the protocol (either in or not in the protocol), and via an included file. The included file declarations are done via a slightly different code path so it makes sense to check them.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

10 months ago
Duplicate of this bug: 1338718
(Assignee)

Comment 4

10 months ago
I added some more missing tests, that are error tests that should fail when the manager is weaker than the managee.

Comment 5

10 months ago
mozreview-review
Comment on attachment 8836138 [details]
Bug 1338594 - Add more basic IPDL tests.

https://reviewboard.mozilla.org/r/111578/#review113590
Attachment #8836138 - Flags: review?(kchen) → review+

Comment 6

10 months ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/535de0c3e91d
Add more basic IPDL tests. r=kanru

Comment 7

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/535de0c3e91d
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.