[swift-3-regression] Save Login dialog does not have proper width

VERIFIED FIXED

Status

()

VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: njpark, Assigned: fluffyemily)

Tracking

({reproducible})

unspecified
Other
iOS
reproducible

Firefox Tracking Flags

(fxios-v7.0 affected, fxios7.0+)

Details

(Whiteboard: [mobileCore])

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Created attachment 8836147 [details]
Screen Shot 2017-02-10 at 1.16.12 PM.png

The save login dialog look much cramped now.
(Reporter)

Updated

2 years ago
No longer depends on: 1338338
Keywords: crash
(Reporter)

Comment 1

2 years ago
Note: This is not reproducible when accessing sites like amazon or ebay, but can be reproduced consistently when running UITests/AuthenticationTests.swift.  Only difference I see is that other sites without this issue don't ask for username/password on a modal dialog- perhaps it might have something to do with it?
I was also able to reproduce this on swift-3-migration 226274236.
status-fxios-v7.0: --- → affected
tracking-fxios: --- → ?
(Assignee)

Updated

2 years ago
Assignee: nobody → etoop
Status: NEW → ASSIGNED
(Assignee)

Comment 3

2 years ago
Created attachment 8837667 [details] [review]
Pull request
Attachment #8837667 - Flags: review?(sleroux)
Attachment #8837667 - Flags: feedback?(npark)
(Reporter)

Comment 4

2 years ago
Comment on attachment 8837667 [details] [review]
Pull request

Dialog looks good now and it also appears on top of the keyboard when keyboard appears as well.
Attachment #8837667 - Flags: feedback?(npark) → feedback+
Attachment #8837667 - Flags: review?(sleroux) → review+
(Assignee)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Verifying as fix on master f35aff8.
Status: RESOLVED → VERIFIED

Updated

2 years ago
tracking-fxios: ? → 7.0+
You need to log in before you can comment on or make changes to this bug.