1338640 - ParseString wide character version

Status: NEW

(Core :: XPCOM, defect, P3)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

ParseString works with CString/char; it'd be handy to have a String/char16_t version.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Bug 1338640: Wide character version of ParseString.

Review commit: https://reviewboard.mozilla.org/r/111622/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111622/

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Using the new ParseString

My immediate use for this (new) version of the function went away.  There is one place (toolkit/components/places/nsNavHistoryResult.cpp) where this new one could be used, perhaps more.
I don't know if that's worth the new version or not.

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Milan Sreckovic [:milan] from comment #2)
> Created attachment 8836208 [details] [diff] [review]
> Using the new ParseString
> 
> My immediate use for this (new) version of the function went away.  There is
> one place (toolkit/components/places/nsNavHistoryResult.cpp) where this new
> one could be used, perhaps more.
> I don't know if that's worth the new version or not.

That would be a nice cleanup.  But an even better cleanup would be to make ParseString go away in favor of the recently added Split:

https://dxr.mozilla.org/mozilla-central/source/xpcom/string/nsTSubstring.h#715

since that's more idiomatic.  Should we drop this bug, or morph it into replacing ParseString with Split()?

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Morph is probably a better choice.  I will do some performance measurements, just to see how the two compare in places where ParseString performance matters.

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8836184 [details]
Bug 1338640: Wide character version of ParseString.

https://reviewboard.mozilla.org/r/111622/#review113406

Going to drop this review for now, then.

Comment 6

[khalisthingsc]

Without additional context or information about the programming language or framework http://clickspeedtest.info/clicks-in-20-sec you are working with, I can provide a general idea of what a wide character version of a string-parsing function might look like in C++.