1338673 - Implement GeckoActivityStatus in FxAccountStatusActivity

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Jan Henning [:JanH]]

Compare the failed attempt from bug 1336734 (https://reviewboard.mozilla.org/r/110172/diff/2/).

This requires either some sort of modification to our build system, so the compiler can find GeckoActivityStatus and GeckoApplication (which live in android/base) when building the FxAccountStatusActivity (which lives under android/services), or else us completely switching over to Gradle builds, where this "just works".

Comment 1

[Jan Henning [:JanH]]

Attachment: GeckoApplication activity pause debug logging

Review commit: https://reviewboard.mozilla.org/r/111702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111702/

Comment 2

[Jan Henning [:JanH]]

Attachment: Bug 1338673 - Implement GeckoActivityStatus for the FxAccountStatusActivity.

Since we want to avoid pausing Gecko when entering this activity, it must implement this interface so we can still properly pause Gecko if we get backgrounded while on the Sync preferences screen.

Most actions here are actually done via the application context (i.e. GeckoApplication), so overriding startActivity et al. and using mGeckoActivityOpened doesn't achieve all that much for most cases, but since we currently at most exit the screen (activity is finishing, so won't trigger a GeckoThread.onPause() call) and stay within our application (open a new tab in Firefox), we're still fine for now.

Review commit: https://reviewboard.mozilla.org/r/111704/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111704/

Comment 3

[Nick Alexander :nalexander [he/him]]

This is do-able, but not trivial.  There are examples of sharing pieces in the tree; see https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/moz.build?q=path%3Aandroid%2Fbase%2Fmoz.build&redirect_type=single#39.  However, it requires a lot of discipline to minimize the shared code, and might not be possible for something so tied to the Fennec Java code.

Comment 4

[Jan Henning [:JanH]]

Thanks for the hint. I'll leave that for another day, but it might be doable if I split out onActivityPause/Resume into a separate interface, since that's the only bit of GeckoApplication I'm really interested in here.

Comment 5

[Jan Henning [:JanH]]

Yup, splitting those two functions into their own interface and moving that into a JAR that is accessible for android/services as well works.

Comment 6

[Jan Henning [:JanH]]

No longer needed because of bug 1346413.