1338674 - close compose windows in cloudfile/attachment tests

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[:aceman]

+++ This bug was initially created as a clone of Bug #1337713 comment 21 and comment 18 +++

Some Thunderbird tests in mozmill/attachment and mozmill/cloudfile open compose windows, attach some remote files (probabbly inaccessible) and then leave the windows open while proceeding to next tests. This clutters the view when observing the test run (for debugging tests) and also each test should clean up after itself to not randomly affect state for the following tests.

Comment 1

[:aceman]

Attachment: patch

Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=963e4c3a501b10a3dc680ad9a0ad0b8596bd399e

Comment 2

[ISHIKAWA, Chiaki]

(In reply to :aceman from comment #0)
> +++ This bug was initially created as a clone of Bug #1337713 comment 21 and
> comment 18 +++
> 
> Some Thunderbird tests in mozmill/attachment and mozmill/cloudfile open
> compose windows, attach some remote files (probabbly inaccessible) and then
> leave the windows open while proceeding to next tests. This clutters the
> view when observing the test run (for debugging tests) and also each test
> should clean up after itself to not randomly affect state for the following
> tests.

aceman, while you are at it, can you take a lookt at
https://bugzilla.mozilla.org/show_bug.cgi?id=960589
Bug 960589 - Excessive number of windows created during |make mozmill| test run of thunderbird (comm-central) ?

Some tests seem to forget to close the windows very badly.

TIA

Comment 3

[:aceman]

Yes, that is the point of this bug:)
I know that it irritates you (and me) and also may slow down tests if there are many windows open.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8836269 [details] [diff] [review]
patch

Nice clean-up!

Comment 5

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/25bcbef564df0d888cf5cc90f9c277b97a575f3e
Thanks, cleaning up tests is not a trivial task.