Closed Bug 1338674 Opened 4 years ago Closed 4 years ago

close compose windows in cloudfile/attachment tests

Categories

(Thunderbird :: Testing Infrastructure, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 54.0

People

(Reporter: aceman, Assigned: aceman)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1337713 comment 21 and comment 18 +++

Some Thunderbird tests in mozmill/attachment and mozmill/cloudfile open compose windows, attach some remote files (probabbly inaccessible) and then leave the windows open while proceeding to next tests. This clutters the view when observing the test run (for debugging tests) and also each test should clean up after itself to not randomly affect state for the following tests.
(In reply to :aceman from comment #0)
> +++ This bug was initially created as a clone of Bug #1337713 comment 21 and
> comment 18 +++
> 
> Some Thunderbird tests in mozmill/attachment and mozmill/cloudfile open
> compose windows, attach some remote files (probabbly inaccessible) and then
> leave the windows open while proceeding to next tests. This clutters the
> view when observing the test run (for debugging tests) and also each test
> should clean up after itself to not randomly affect state for the following
> tests.

aceman, while you are at it, can you take a lookt at
https://bugzilla.mozilla.org/show_bug.cgi?id=960589
Bug 960589 - Excessive number of windows created during |make mozmill| test run of thunderbird (comm-central) ?

Some tests seem to forget to close the windows very badly.

TIA
Yes, that is the point of this bug:)
I know that it irritates you (and me) and also may slow down tests if there are many windows open.
Blocks: 960589
Comment on attachment 8836269 [details] [diff] [review]
patch

Nice clean-up!
Attachment #8836269 - Flags: review?(mkmelin+mozilla) → review+
https://hg.mozilla.org/comm-central/rev/25bcbef564df0d888cf5cc90f9c277b97a575f3e
Thanks, cleaning up tests is not a trivial task.
Severity: trivial → normal
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 54.0
You need to log in before you can comment on or make changes to this bug.