Remove Outlook Express import (since XP is no longer supported)

RESOLVED FIXED in Thunderbird 54.0

Status

MailNews Core
Import
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: Jorg K (GMT+1), Assigned: Paenglab)

Tracking

Trunk
Thunderbird 54.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

Comment hidden (empty)
(Reporter)

Comment 1

11 months ago
Created attachment 8836271 [details] [diff] [review]
1338715.patch

Richard made a start here ;-)
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8836271 - Flags: review+
(Reporter)

Comment 2

11 months ago
https://hg.mozilla.org/comm-central/rev/da132ad0ba30fbcf94638ceebc1a81149e2a61c1
Landed as bustage fix.

The complete removal of the OE import will follow.
(Reporter)

Updated

11 months ago
Assignee: jorgk → richard.marti
(Reporter)

Comment 3

11 months ago
This isn't hard. One patch to remove mailnews/import/oexpress and a second one to remove any traces of oexpress:
https://dxr.mozilla.org/comm-central/search?q=regexp%3A%5Cboexpress%5Cb&redirect=false

Nice job for a rainy afternoon. If it compiles and no Outlook Express shows in any import, then it's right ;-)
(Assignee)

Comment 4

11 months ago
Created attachment 8836321 [details] [diff] [review]
Remove the Outlook Express import files

Also when it's sunny here, I had some time to remove the files. ;-)
Attachment #8836321 - Flags: review?(jorgk)
(Assignee)

Comment 5

11 months ago
Created attachment 8836322 [details] [diff] [review]
Delete all traces to Outlook Express importer

Needed some more than your regex but it was a good start.

Not yet checked if there are tests for this importer.
Attachment #8836322 - Flags: review?(jorgk)
(Reporter)

Comment 6

11 months ago
Comment on attachment 8836321 [details] [diff] [review]
Remove the Outlook Express import files

Wasn't hard, was it ;-)
Attachment #8836321 - Flags: review?(jorgk) → review+
(Assignee)

Comment 7

11 months ago
Ah, there is test_oe_settings.js.
(Reporter)

Comment 8

11 months ago
Comment on attachment 8836322 [details] [diff] [review]
Delete all traces to Outlook Express importer

I didn't compile this, but I trust good Swiss quality work here ;-)
Meanwhile, German poor quality work can't be trusted. I'm referring to the terribly wrong DXR query which I posted in comment #3 which misses half the stuff that you found. Well done! Vertrauen ist gut, Kontrolle ist besser (Lenin) ;-)
Attachment #8836322 - Flags: review?(jorgk) → review+
(Reporter)

Comment 9

11 months ago
(In reply to Richard Marti (:Paenglab) from comment #7)
> Ah, there is test_oe_settings.js.
3rd patch is easiest. Also: mailnews/import/test/unit/xpcshell.ini
(Assignee)

Comment 10

11 months ago
Created attachment 8836323 [details] [diff] [review]
Remove the Outlook Express importer test

And now the test removal.
Attachment #8836323 - Flags: review?(jorgk)
(Reporter)

Comment 12

11 months ago
Comment on attachment 8836323 [details] [diff] [review]
Remove the Outlook Express importer test

Thanks.
Attachment #8836323 - Flags: review?(jorgk) → review+
You need to log in before you can comment on or make changes to this bug.