Closed Bug 1338726 Opened 5 years ago Closed 5 years ago

Sidebar icon appears only on second tab

Categories

(WebExtensions :: Frontend, defect, P2)

defect

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: andy+bugzilla, Assigned: mixedpuppy)

References

Details

(Whiteboard: triaged)

Attachments

(3 files)

Attached file sidebar.xpi
Install an add-on with a sidebar and no icon. For the first tab, the icon does not appear in the sidebar menu. Then open a new tab, icon appears.
Attached video no-icon-first-tab.mov
Assignee: nobody → mixedpuppy
Blocks: 1208596
Looks like the generic icon used when no icon defined.  I'm guessing (based on my test addon which I didn't see that with) that defining an icon doesn't have the same issue.
Priority: -- → P2
Whiteboard: triaged
STR:
- install attached xpi
- open new window
- check for icon in toolbarbutton

This turned out to be from opening an new window, which didn't go through the code path that added the style for the icon.
Comment on attachment 8836889 [details]
Bug 1338726 fix icon style for new windows,

https://reviewboard.mozilla.org/r/112208/#review113472

Looks good, but please add a test.
Attachment #8836889 - Flags: review?(kmaglione+bmo)
Comment on attachment 8836889 [details]
Bug 1338726 fix icon style for new windows,

https://reviewboard.mozilla.org/r/112208/#review114272
Attachment #8836889 - Flags: review?(kmaglione+bmo) → review+
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6a03b96cc5ba
fix icon style for new windows, r=kmag
https://hg.mozilla.org/mozilla-central/rev/6a03b96cc5ba
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.