1338726 - Sidebar icon appears only on second tab

Status: RESOLVED FIXED

(WebExtensions :: Frontend, defect, P2)

Description

[Andy McKay]

Attachment: sidebar.xpi

Install an add-on with a sidebar and no icon. For the first tab, the icon does not appear in the sidebar menu. Then open a new tab, icon appears.

Comment 1

[Andy McKay]

Attachment: no-icon-first-tab.mov

Comment 2

[Shane Caraveo (:mixedpuppy)]

Looks like the generic icon used when no icon defined.  I'm guessing (based on my test addon which I didn't see that with) that defining an icon doesn't have the same issue.

Comment 3

[Shane Caraveo (:mixedpuppy)]

STR:
- install attached xpi
- open new window
- check for icon in toolbarbutton

This turned out to be from opening an new window, which didn't go through the code path that added the style for the icon.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1338726 fix icon style for new windows,

Review commit: https://reviewboard.mozilla.org/r/112208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112208/

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 8836889 [details]
Bug 1338726 fix icon style for new windows,

https://reviewboard.mozilla.org/r/112208/#review113472

Looks good, but please add a test.

Comment 6

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8836889 [details]
Bug 1338726 fix icon style for new windows,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112208/diff/1-2/

Comment 7

[Kris Maglione [:kmag]]

Comment on attachment 8836889 [details]
Bug 1338726 fix icon style for new windows,

https://reviewboard.mozilla.org/r/112208/#review114272

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a03b96cc5ba
fix icon style for new windows, r=kmag

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6a03b96cc5ba