Closed Bug 1338740 Opened 3 years ago Closed 3 years ago

ScopedBindPBO inherits from ScopedGLWrapper<ScopedPackState>, not ScopedGLWrapper<ScopedBindPBO>

Categories

(Core :: Canvas: WebGL, defect, P1, major)

defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox-esr45 --- unaffected
firefox51 --- unaffected
firefox52 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

(Whiteboard: gfx-noted)

Attachments

(1 file)

Oops.
Whiteboard: gfx-noted
Comment on attachment 8836296 [details]
Bug 1338740 - ScopedBindPBO should not inherit from ScopedGLWrapper<other class>. -

https://reviewboard.mozilla.org/r/111758/#review113182
Attachment #8836296 - Flags: review?(dmu) → review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd3f337f0d9c
ScopedBindPBO should not inherit from ScopedGLWrapper<other class>. - r=daoshengmu
https://hg.mozilla.org/mozilla-central/rev/dd3f337f0d9c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Comment on attachment 8836296 [details]
Bug 1338740 - ScopedBindPBO should not inherit from ScopedGLWrapper<other class>. -

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: Risky execution when ScopedBindPBO is used.
Fix Landed on Version: 54
Risk to taking this patch (and alternatives if risky): none
String or UUID changes made by this patch: none

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]: Risky execution when ScopedBindPBO is used.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: esr52
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Obvious error has an obvious fix.
[String changes made/needed]: none
Attachment #8836296 - Flags: approval-mozilla-esr52?
Attachment #8836296 - Flags: approval-mozilla-beta?
Attachment #8836296 - Flags: approval-mozilla-aurora?
Comment on attachment 8836296 [details]
Bug 1338740 - ScopedBindPBO should not inherit from ScopedGLWrapper<other class>. -

Fix a WebGL2 issue. Aurora53+.
Attachment #8836296 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
needs rebase for aurora

grafting 398741:dd3f337f0d9c "Bug 1338740 - ScopedBindPBO should not inherit from ScopedGLWrapper<other class>. - r=daoshengmu"
merging gfx/gl/ScopedGLHelpers.cpp
merging gfx/gl/ScopedGLHelpers.h
warning: conflicts while merging gfx/gl/ScopedGLHelpers.cpp! (edit, then use 'hg resolve --mark')
warning: conflicts while merging gfx/gl/ScopedGLHelpers.h! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')
Flags: needinfo?(jgilbert)
Assignee: nobody → jgilbert
Comment on attachment 8836296 [details]
Bug 1338740 - ScopedBindPBO should not inherit from ScopedGLWrapper<other class>. -

esr52 is being kept in sync with beta during this cycle
Attachment #8836296 - Flags: approval-mozilla-esr52?
Attachment #8836296 - Flags: approval-mozilla-beta?
Attachment #8836296 - Flags: approval-mozilla-beta-
Attachment #8836296 - Flags: approval-mozilla-aurora-
Attachment #8836296 - Flags: approval-mozilla-aurora+
Perfect then.
Flags: needinfo?(jgilbert)
You need to log in before you can comment on or make changes to this bug.