Closed Bug 1338777 Opened 3 years ago Closed 3 years ago

The TB test mozmill/composition/test-save-changes-on-quit.js does not close one of its compose windows

Categories

(Thunderbird :: Testing Infrastructure, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 54.0

People

(Reporter: aceman, Assigned: aceman)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The TB test mozmill/composition/test-save-changes-on-quit.js does not close one of its compose windows in test test_window_quit_state_reset_on_aborted_quit().
Attached patch patchSplinter Review
Attachment #8836328 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8836328 [details] [diff] [review]
patch

Nice clean-up!
I'm not sure why that's not included in bug 1338674 since it's more of the same. 
You might want to beautify the MODULE_REQUIRES as well. Up to you.
Attachment #8836328 - Flags: review?(mkmelin+mozilla) → review+
I didn't know this place needs fixing when I did 1338674 and I wanted to split the jobs into per-test-folder patches.

I do not need to cleanup MODULE_REQUIRES array here if it is just reindenting, rewrapping. In the other patch I added some new modules to it that were missing (only to be later loaded by the manual code). That is the point of my for (let lib of MODULE_REQUIRES) {} loop so that the MODULE_REQUIRES and the modules loaded in setupModule() do not desynch.
OK, thanks for the clarification. Landing this in the afternoon.
https://hg.mozilla.org/comm-central/rev/f99ba4305a4a89614a0328dd850ff26945a669c9
Sorry about the delay in landing this, I had to wait for the right moment ;-)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 54.0
You need to log in before you can comment on or make changes to this bug.