1338887 - nsRefreshDriver::DispatchAnimationEvents() should use AutoTArray to avoid allocations in common cases

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

I was profiling something else, but nsRefreshDriver::DispatchAnimationEvents() showed up there because of the allocations it does.

We could probably use reasonable large AutoTArray here, perhaps size 32?

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: animation_events.diff

Comment 2

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8836461 [details] [diff] [review]
animation_events.diff

Review of attachment 8836461 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Olli.

Looks good to me.

Like this, print events are using the same implementation. (i.e. nsCOMArray instead AutoTArray) [1] 
[1] https://dxr.mozilla.org/mozilla-central/rev/0eef1d5a39366059677c6d7944cfe8a97265a011/layout/base/nsDocumentViewer.cpp#429-447

Should we change this implementation?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Sure, but print events are very rarely used feature, so doesn't matter too much. DispatchAnimationEvents is being called all the time.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ce55d187ed5
try to avoid extra allocations when dispatching animation events, r=mantaroh

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8ce55d187ed5