1338915 - Compression-related error message in type.py is trimmed when it shouldn't be

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Andrew McCreight [:mccr8]]

Here is some code from type.py:

if (mtype.compress and
    (not mtype.isAsync() or mtype.isCtor() or mtype.isDtor())):
    self.error(
        loc,
        "message `%s' in protocol `%s' requests compression but is not async or is special (ctor or dtor)",
        mname[:-len('constructor')], pname)

The message name |mname| is trimmed by the length of "constructor", but mname isn't necessarily a constructor: it can also be a non-async message or a delete message (a "destructor"). In those two cases, mname should not be trimmed.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1338915 - Print a more specific message for invalid compression.

Review commit: https://reviewboard.mozilla.org/r/112400/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112400/

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 8837209 [details]
Bug 1338915 - Print a more specific message for invalid compression.

https://reviewboard.mozilla.org/r/112400/#review114130

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5839de2e4ec7
Print a more specific message for invalid compression. r=kanru

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5839de2e4ec7