Closed Bug 1338932 Opened 7 years ago Closed 7 years ago

Compilation warning

Categories

(Core :: Audio/Video: Playback, defect)

Unspecified
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(1 file)

In file included from /home/jyavenard/Work/Mozilla/obj-ff-android-dbg/dom/media/platforms/Unified_cpp_dom_media_platforms0.cpp:92:0:
/home/jyavenard/Work/Mozilla/mozilla-central/dom/media/platforms/android/RemoteDataDecoder.cpp: In member function 'virtual void mozilla::RemoteVideoDecoder::CallbacksSupport::HandleOutput(mozilla::jni::ObjectBase<mozilla::java::Sample>::Param)':
Warning: -Wmaybe-uninitialized in /home/jyavenard/Work/Mozilla/mozilla-central/dom/media/platforms/android/RemoteDataDecoder.cpp: 'durationUs' may be used uninitialized in this function
/home/jyavenard/Work/Mozilla/mozilla-central/dom/media/platforms/android/RemoteDataDecoder.cpp:193:58: warning: 'durationUs' may be used uninitialized in this function [-Wmaybe-uninitialized]
                        mDecoder->mConfig.mDisplay.height));
                                                          ^

Harmless, as the only case it won't be initialised is when EOS sample is received, but should be fixed anyway.
Assignee: nobody → jyavenard
Comment on attachment 8836534 [details]
Bug 1338932: Initialise variable.

https://reviewboard.mozilla.org/r/111940/#review113186

Good catch. Thanks!
Attachment #8836534 - Flags: review?(jolin) → review+
https://hg.mozilla.org/mozilla-central/rev/5b095aef3863
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: