Thunderbird installation fails due to missing autoconfig files

RESOLVED FIXED in Thunderbird 54.0

Status

MailNews Core
Build Config
--
minor
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: aceman, Assigned: frg)

Tracking

Trunk
Thunderbird 54.0
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
make install of current Thunderbird trunk fails for me with:

$ make -f client.mk
$ make -f client.mk install INSTALL_SDK=
...
Error: TB-hg/tbird-bin/mail/installer/package-manifest:255: Missing file(s): bin/defaults/autoconfig/prefcalls.js
Error: TB-hg/tbird-bin/mail/installer/package-manifest:278: Missing file(s): bin/components/autoconfig.xpt
Traceback (most recent call last):
  File "TB-hg/mozilla/toolkit/mozapps/installer/packager.py", line 418, in <module>
    main()
  File "TB-hg/mozilla/toolkit/mozapps/installer/packager.py", line 370, in main
    copier.add(mozpath.join(respath, 'removed-files'), removals)
  File "/usr/lib64/python2.7/contextlib.py", line 24, in __exit__
    self.gen.next()
  File "TB-hg/mozilla/python/mozbuild/mozpack/errors.py", line 131, in accumulate
    raise AccumulatedErrors()
mozpack.errors.AccumulatedErrors
gmake[2]: *** [TB-hg/mozilla/toolkit/mozapps/installer/packager.mk:41: stage-package] Error 1
gmake[2]: Leaving directory 'TB-hg/tbird-bin/mail/installer'
gmake[1]: *** [TB-hg/mozilla/../mail/build.mk:19: install] Error 2
gmake[1]: Leaving directory 'TB-hg/tbird-bin'
gmake: *** [client.mk:404: install] Error 2

I don't know what is causing this. I do have some --disable-* options in my mozconfig, but nothing resembles "autoconfig".
Maybe something in mail/installer/Makefile.in needs to be made conditional on some config option, similar to bug 1328156.
(Reporter)

Updated

a year ago
Summary: Installation fails with --disable-ldap → Thunderbird installation fails due to missing autoconfig files
(Assignee)

Comment 1

a year ago
Do you have a MOZ_EXTENSIONS in your config or something else with extension in it? 

make -f client.mk and make -f client.mk configure are working ok?

Comment 2

a year ago
Strange, autoconfig.xpt seems to be a file that's included regularly:
https://dxr.mozilla.org/comm-central/search?q=autoconfig.xpt&redirect=false
(Reporter)

Comment 3

a year ago
(In reply to Frank-Rainer Grahl from comment #1)
> Do you have a MOZ_EXTENSIONS in your config or something else with extension
> in it? 

I see nothing like that. This is what I have now in mozconfig:

ac_add_options --host=x86_64-linux-gnu
ac_add_options --enable-application=mail
ac_add_options --disable-wmf
ac_add_options --disable-webrtc
ac_add_options --disable-pulseaudio
ac_add_options --disable-parental-controls
ac_add_options --disable-gamepad
ac_add_options --disable-negotiateauth
ac_add_options --disable-system-extension-dirs
ac_add_options --disable-pref-extensions
ac_add_options --disable-updater
ac_add_options --disable-crashreporter
ac_add_options --disable-printing
ac_add_options --disable-necko-wifi
ac_add_options --disable-dbus
ac_add_options --disable-gconf
ac_add_options --disable-gio
ac_add_options --disable-ldap
ac_add_options --enable-debug #zapne napr. vypisovanie textov z NS_ASSERTION
ac_add_options --disable-optimize

> make -f client.mk and make -f client.mk configure are working ok?

Yes, these work and I use them primarily. I'm no fan of 'mach'.

(In reply to Jorg K (GMT+1) from comment #2)
> Strange, autoconfig.xpt seems to be a file that's included regularly:
> https://dxr.mozilla.org/comm-central/search?q=autoconfig.xpt&redirect=false

I just do not have this file anywhere. It probably isn't generated.
(Assignee)

Comment 4

a year ago
My guess would be:
ac_add_options --disable-pref-extensions

The stuff is in pref.

I think this one is dead but not sure:
ac_add_options --disable-gamepad
(Reporter)

Comment 5

a year ago
It seems with that config option enabled the installation moves forward. I don't know what it actually does and it if is successful, but it does progress after the reported errors.

Can you make the patch?
It seems that option sets MOZ_PREF_EXTENSIONS in oldconfigure.
(Assignee)

Comment 6

a year ago
> I don't know what it actually does and it if is successful, but it does progress after the reported errors.

Only LDAP seems to check the pref but without it I am not sure if proxy config via an url would still work.

>Can you make the patch?

If only for the installer then yes. 

>> It seems that option sets MOZ_PREF_EXTENSIONS in oldconfigure.

Yes++
(Reporter)

Comment 7

a year ago
Yes, patch for the installer only so that it does not include those 2 files when --disable-pref-extensions is set.
(Assignee)

Comment 8

a year ago
Created attachment 8838850 [details] [diff] [review]
1338934-PrefExtensions.patch

Here you go.
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Attachment #8838850 - Flags: review?(acelists)
(Reporter)

Comment 9

a year ago
Comment on attachment 8838850 [details] [diff] [review]
1338934-PrefExtensions.patch

Review of attachment 8838850 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, worked.
Attachment #8838850 - Flags: review?(acelists) → review+
(Assignee)

Comment 10

a year ago
> Thanks, worked.

Jupp. Build it myself with disable and still hope that enable works :)
Keywords: checkin-needed

Comment 11

a year ago
https://hg.mozilla.org/comm-central/rev/afa0caf4012c5beb229866dfee8af236d2f0dfd4
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 54.0
You need to log in before you can comment on or make changes to this bug.