Closed
Bug 1338949
Opened 8 years ago
Closed 8 years ago
Add const to kRedirMap
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.23 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Moves 576 bytes to the read-only segment.
(This is starting to get to diminishing returns, so this is probably the last such array that I'll bother with.)
Also: how come this code is duplicated?
Attachment #8836545 -
Flags: review?(bzbarsky)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8836545 [details] [diff] [review]
kRedirMap
r=me
There's a redirector for built-in Gecko things that all Gecko-based apps have, and a separate one for Firefox-specific things.... It definitely would be nice if they could share more code.
Attachment #8836545 -
Flags: review?(bzbarsky) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f290f11df56d
Add const to kRedirMap. r=bz
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•