Closed
Bug 1338951
Opened 7 years ago
Closed 7 years ago
Move PhaseInfo to a read-only data section
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
833 bytes,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Please see bug 1334254 comment 0 for background. This patch moves 1.5k of data to the read-only section. It may have been cleaner to try to rework this with constexpr or something, but I figure nobody will mind this change, seeing as the other three fields on the struct are non-const already.
Attachment #8836546 -
Flags: review?(sphink)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8836546 [details] [diff] [review] PhaseInfo Review of attachment 8836546 [details] [diff] [review]: ----------------------------------------------------------------- Oh right, I remember reading about this. Thanks!
Attachment #8836546 -
Flags: review?(sphink) → review+
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5e53a0e7848c Remove const from PhaseInfo for better codegen on Windows. r=sfink
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5e53a0e7848c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•