Closed
Bug 1338985
Opened 7 years ago
Closed 7 years ago
Assertion failure: !Failed() in DragDataProducer::Produce
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: m_kato, Assigned: smaug)
Details
Attachments
(1 file)
688 bytes,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
After using document.execCommand("enableInlineTableEditing", false, "true"), when I use mouse operation into table, the following assertion occur. In dom\base\nscontentareadragdrop.cpp: ... void DragDataProducer::GetNodeString(nsIContent* inNode, nsAString & outNodeString) { ... mozilla::ErrorResult rv; RefPtr<nsRange> range = doc->CreateRange(rv); if (range) { range->SelectNode(*node, rv); range->ToString(outNodeString); } ... Although CreateRange or SelectNode returns error, we don't reset error. We should use IgnoredErrorResult instead. Assertion failure: !Failed(), at c:\Development\hg.mozilla.org\objdir-ib\dist\include\mozilla/ErrorResult.h:443 #01: DragDataProducer::Produce (c:\development\hg.mozilla.org\mozilla-inbound\dom\base\nscontentareadragdrop.cpp:644) #02: nsContentAreaDragDrop::GetDragData (c:\development\hg.mozilla.org\mozilla-inbound\dom\base\nscontentareadragdrop.cpp:129) #03: mozilla::EventStateManager::DetermineDragTargetAndDefaultData (c:\development\hg.mozilla.org\mozilla-inbound\dom\events\eventstatemanager.cpp:1826) #04: mozilla::EventStateManager::GenerateDragGesture (c:\development\hg.mozilla.org\mozilla-inbound\dom\events\eventstatemanager.cpp:1723) #05: mozilla::EventStateManager::PreHandleEvent (c:\development\hg.mozilla.org\mozilla-inbound\dom\events\eventstatemanager.cpp:722) #06: mozilla::PresShell::HandleEventInternal (c:\development\hg.mozilla.org\mozilla-inbound\layout\base\presshell.cpp:8122) #07: mozilla::PresShell::HandlePositionedEvent (c:\development\hg.mozilla.org\mozilla-inbound\layout\base\presshell.cpp:7957) #08: mozilla::PresShell::HandleEvent (c:\development\hg.mozilla.org\mozilla-inbound\layout\base\presshell.cpp:7750) #09: nsViewManager::DispatchEvent (c:\development\hg.mozilla.org\mozilla-inbound\view\nsviewmanager.cpp:816) #10: nsView::HandleEvent (c:\development\hg.mozilla.org\mozilla-inbound\view\nsview.cpp:1135) #11: nsWindow::DispatchEvent (c:\development\hg.mozilla.org\mozilla-inbound\widget\windows\nswindow.cpp:4115) #12: nsBaseWidget::DispatchInputEvent (c:\development\hg.mozilla.org\mozilla-inbound\widget\nsbasewidget.cpp:1236) #13: nsWindow::DispatchMouseEvent (c:\development\hg.mozilla.org\mozilla-inbound\widget\windows\nswindow.cpp:4516) #14: nsWindow::ProcessMessage (c:\development\hg.mozilla.org\mozilla-inbound\widget\windows\nswindow.cpp:5411) #15: nsWindow::WindowProcInternal (c:\development\hg.mozilla.org\mozilla-inbound\widget\windows\nswindow.cpp:4863) #16: CallWindowProcCrashProtected (c:\development\hg.mozilla.org\mozilla-inbound\xpcom\base\nscrashonexception.cpp:35) #17: nsWindow::WindowProc (c:\development\hg.mozilla.org\mozilla-inbound\widget\windows\nswindow.cpp:4815) #18: SetManipulationInputTarget[C:\WINDOWS\System32\USER32.dll +0x2d2b3] #19: DispatchMessageW[C:\WINDOWS\System32\USER32.dll +0xe88a] #20: DispatchMessageW[C:\WINDOWS\System32\USER32.dll +0xe1e4] #21: DispatchMessageW[C:\WINDOWS\System32\USER32.dll +0xdfa0] #22: nsAppShell::ProcessNextNativeEvent (c:\development\hg.mozilla.org\mozilla-inbound\widget\windows\nsappshell.cpp:376) #23: nsBaseAppShell::DoProcessNextNativeEvent (c:\development\hg.mozilla.org\mozilla-inbound\widget\nsbaseappshell.cpp:139) #24: nsBaseAppShell::OnProcessNextEvent (c:\development\hg.mozilla.org\mozilla-inbound\widget\nsbaseappshell.cpp:289) #25: nsThread::ProcessNextEvent (c:\development\hg.mozilla.org\mozilla-inbound\xpcom\threads\nsthread.cpp:1220) #26: NS_ProcessNextEvent (c:\development\hg.mozilla.org\mozilla-inbound\xpcom\threads\nsthreadutils.cpp:389) #27: mozilla::ipc::MessagePump::Run (c:\development\hg.mozilla.org\mozilla-inbound\ipc\glue\messagepump.cpp:124) #28: MessageLoop::RunInternal (c:\development\hg.mozilla.org\mozilla-inbound\ipc\chromium\src\base\message_loop.cc:238) #29: MessageLoop::RunHandler (c:\development\hg.mozilla.org\mozilla-inbound\ipc\chromium\src\base\message_loop.cc:232) #30: MessageLoop::Run (c:\development\hg.mozilla.org\mozilla-inbound\ipc\chromium\src\base\message_loop.cc:212) #31: nsBaseAppShell::Run (c:\development\hg.mozilla.org\mozilla-inbound\widget\nsbaseappshell.cpp:158) #32: nsAppShell::Run (c:\development\hg.mozilla.org\mozilla-inbound\widget\windows\nsappshell.cpp:262) #33: nsAppStartup::Run (c:\development\hg.mozilla.org\mozilla-inbound\toolkit\components\startup\nsappstartup.cpp:284) #34: XREMain::XRE_mainRun (c:\development\hg.mozilla.org\mozilla-inbound\toolkit\xre\nsapprunner.cpp:4458) #35: XREMain::XRE_main (c:\development\hg.mozilla.org\mozilla-inbound\toolkit\xre\nsapprunner.cpp:4635) #36: XRE_main (c:\development\hg.mozilla.org\mozilla-inbound\toolkit\xre\nsapprunner.cpp:4726) #37: mozilla::BootstrapImpl::XRE_main (c:\development\hg.mozilla.org\mozilla-inbound\toolkit\xre\bootstrap.cpp:45) #38: do_main (c:\development\hg.mozilla.org\mozilla-inbound\browser\app\nsbrowserapp.cpp:235) #39: NS_internal_main (c:\development\hg.mozilla.org\mozilla-inbound\browser\app\nsbrowserapp.cpp:305) #40: wmain (c:\development\hg.mozilla.org\mozilla-inbound\toolkit\xre\nswindowswmain.cpp:118) #41: __scrt_common_main_seh (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253) #42: BaseThreadInitThunk[C:\WINDOWS\System32\KERNEL32.DLL +0x162c4] #43: RtlSubscribeWnfStateChangeNotification[C:\WINDOWS\SYSTEM32\ntdll.dll +0x60fd9] #44: RtlSubscribeWnfStateChangeNotification[C:\WINDOWS\SYSTEM32\ntdll.dll +0x60fa4]
Comment 1•7 years ago
|
||
Neil, is this something you know about? (Sorry, I feel like I ask that of you often)
Flags: needinfo?(enndeakin)
Comment 2•7 years ago
|
||
It seems like comment 1 describes the situation and fix pretty well. I don't know however if the error being generated is a problem. Someone who understands ranges would be a better choice for that.
Flags: needinfo?(enndeakin)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → bugs
Assignee | ||
Comment 3•7 years ago
|
||
Whether or not the behavior should be different is another bug, and that requires STR (I tried document.execCommand("enableInlineTableEditing", false, "true") + mouse usage without luck). Error usage is just clearly wrong.
Attachment #8838652 -
Flags: review?(amarchesini)
Assignee | ||
Comment 4•7 years ago
|
||
That is the change Makoto suggested.
Updated•7 years ago
|
Attachment #8838652 -
Flags: review?(amarchesini) → review+
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dc7d927d3f3a use IgnoredErrorResult when error result isn't used, p=m_kato, r=baku
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/dc7d927d3f3a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•