Closed
Bug 1338997
Opened 7 years ago
Closed 7 years ago
Assertion failure: first.w != 0.0f || second.w != 0.0f, at Polygon.h:41
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox52 | --- | unaffected |
firefox-esr52 | --- | unaffected |
firefox53 | + | wontfix |
firefox54 | + | fixed |
People
(Reporter: cbook, Assigned: mikokm)
References
()
Details
(Keywords: assertion)
Attachments
(2 files)
Assertion failure: first.w != 0.0f || second.w != 0.0f, at c:\builds\moz2_slave\m-aurora-w32-d-000000000000000\build\src\obj-firefox\dist\include\mozilla/gfx/Polygon.h:41 found via bughunter topsite tests and reproduced on aurora tinderbox windows debug builds. Testing other branches now also. Steps to reproduce: -> Load http://www.ikipcollege.edu.my ---> Assertion failure
Reporter | ||
Comment 1•7 years ago
|
||
miko: seems this assertion was added in bug 1274673 - can you take a look ? Thanks :)
Flags: needinfo?(mikokm)
Reporter | ||
Comment 2•7 years ago
|
||
[Tracking Requested - why for this release]: reproduced on trunk also so affects trunk and aurora
status-firefox53:
--- → affected
status-firefox54:
--- → affected
tracking-firefox53:
--- → ?
tracking-firefox54:
--- → ?
Assignee | ||
Comment 3•7 years ago
|
||
Thank you for the report. I can reproduce this on OSX. By the time assertion is hit, the coordinates should already be in the layer space and w-clipping should not be needed. Therefore I think that the assertion or the call to w-clipping might be useless, I'm going to look into it.
Flags: needinfo?(mikokm)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → mikokm
Comment hidden (Intermittent Failures Robot) |
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8840600 [details] Bug 1338997 - Ensure that the transformation matrices are invertible https://reviewboard.mozilla.org/r/115062/#review116946
Attachment #8840600 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 7•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=728ffca89c5d65fed0766e2a7c54ad596e25ee81
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/370364bfc2b5 Ensure that the transformation matrices are invertible r=mattwoodrow
Keywords: checkin-needed
Reporter | ||
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/370364bfc2b5
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•7 years ago
|
Comment 10•7 years ago
|
||
Please request Beta approval on this when you get a chance.
Updated•7 years ago
|
Assignee | ||
Comment 11•7 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #10) > Please request Beta approval on this when you get a chance. I investigated this, and applying this changeset without the perspective: 0 behavior changes in bug 1342229 will raise another assertion regarding non-invertible matrices (when visiting the website on this bug), causing the browser to crash in debug builds. Therefore I do not think uplifting this by itself is worth it.
Flags: needinfo?(mikokm)
Comment 12•7 years ago
|
||
Sounds reasonable. Thanks.
Comment 13•7 years ago
|
||
I assume we'll want this to be nominated for Beta as well to go along with bug 1342229.
Flags: needinfo?(mikokm)
Assignee | ||
Comment 14•7 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #13) > I assume we'll want this to be nominated for Beta as well to go along with > bug 1342229. As per comment #11, I think that it is not strictly needed. For example, we currently have no known test case to verify the visible effect of these changes after the bug 1342229 was fixed.
Flags: needinfo?(mikokm)
Comment 15•7 years ago
|
||
Sorry, I'd misread the "uplifting this by itself" comment to mean "uplifted without bug 1342229" - happy to wontfix for 53 if you don't think there's a user-facing issue here.
You need to log in
before you can comment on or make changes to this bug.
Description
•