1339007 - Replace async getEnabledStatus with initialProcessData for content process init

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect)

Description

[Steve Chung [:steveck]]

After bug 1333682 landed, we could leverage Services.cpmm.initialProcessData to get the status as init instead of async message since content is in content process.

Comment 1

[Steve Chung [:steveck]]

Attachment: Bug 1339007 - Replace async getEnabledStatus with initialProcessData for content process init,

Review commit: https://reviewboard.mozilla.org/r/112678/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112678/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8837532 [details]
Bug 1339007 - Replace async getEnabledStatus with initialProcessData for content process init,

https://reviewboard.mozilla.org/r/112678/#review114100

::: browser/extensions/formautofill/FormAutofillParent.jsm:75
(Diff revision 1)
>      Services.obs.addObserver(this, "advanced-pane-loaded", false);
>  
>      // Observing the pref (and storage) changes
>      Services.prefs.addObserver(ENABLED_PREF, this, false);
>      this._enabled = this._getStatus();
> +    Services.ppmm.initialProcessData.autofillEnabled = this._enabled;

Please move this to a place that gets automatically updated when `_enabled` changes so that it's correct when new processes start after `init` if the status changed after the init of the parent.

::: browser/extensions/formautofill/test/unit/test_enabledStatus.js:18
(Diff revision 1)
>    do_check_eq(formAutofillParent._onStatusChanged.called, true);
> +  do_check_eq(Services.ppmm.initialProcessData.autofillEnabled, false);
>  

Please add a test for the issue I mentioned

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8837532 [details]
Bug 1339007 - Replace async getEnabledStatus with initialProcessData for content process init,

https://reviewboard.mozilla.org/r/112678/#review114104

Comment 4

[Steve Chung [:steveck]]

Comment on attachment 8837532 [details]
Bug 1339007 - Replace async getEnabledStatus with initialProcessData for content process init,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112678/diff/1-2/

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 8837532 [details]
Bug 1339007 - Replace async getEnabledStatus with initialProcessData for content process init,

https://reviewboard.mozilla.org/r/112678/#review114538

::: browser/extensions/formautofill/FormAutofillParent.jsm:156
(Diff revision 2)
> +   *
> +   * @param {boolean} newStatus The latest status we want to set for _enabled
> +   */
> +  _setStatus(newStatus) {
> +    this._enabled = newStatus;
> +    Services.ppmm.initialProcessData.autofillEnabled = newStatus;

Why not put this in onStatusChanged?

Comment 6

[Steve Chung [:steveck]]

Comment on attachment 8837532 [details]
Bug 1339007 - Replace async getEnabledStatus with initialProcessData for content process init,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112678/diff/2-3/

Comment 7

[Steve Chung [:steveck]]

nit fixed, thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/419a12740203
Replace async getEnabledStatus with initialProcessData for content process init, r=MattN

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/419a12740203