Closed
Bug 1339029
Opened 7 years ago
Closed 7 years ago
Remove unused |method| parameter from DataView read/write methods
Categories
(Core :: JavaScript: Standard Library, defect)
Core
JavaScript: Standard Library
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
11.44 KB,
patch
|
evilpie
:
review+
|
Details | Diff | Splinter Review |
The parameter was previously used in error messages, but now it's no longer used.
|
Assignee | |
Comment 1•7 years ago
|
||
The patch simply removes the unused |method| parameter from DataViewObject::read and DataViewObject::write.
Attachment #8836665 -
Flags: review?(evilpies)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8836665 [details] [diff] [review] bug1339029.patch Thanks.
Attachment #8836665 -
Flags: review?(evilpies) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ee44c2b6bb129745b4dcfa16afea4aec788aef9
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/677f27ed41b7 Remove unused parameter from internal DataView read/write methods. r=evilpie
Keywords: checkin-needed
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/677f27ed41b7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•