Closed
Bug 1339041
Opened 8 years ago
Closed 8 years ago
trigger all talos jobs: Taskcluster: ext.certificate.expiry < now
Categories
(Tree Management :: Treeherder, defect, P1)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: bstack)
References
Details
Attachments
(1 file)
I hit this error while executing the 'trigger all talos jobs' option from treeherder.
I am not sure what that means, but this is the first time I have seen this.
Comment 1•8 years ago
|
||
Treeherder login sessions (Django sessions) are set to last 2 weeks.
Bug 1289824 added support for using the Taskcluster token to perform actions, rather than routing them through Treeherder, by storing them in localstorage and sending them client side when eg using "trigger all talos jobs". However these tokens (generated via the login.taskcluster.net SSO login flow) are only valid for 3 days, and the taskcluster team don't want to extend the validity. We also don't feel that it's right to inconvenience all other Treeherder users by reducing the Django session from 2 weeks to 3 days.
As such, we're left with a situation where someone can still be logged into Treeherder, but their taskcluster token in localstorage has expired. My understanding that bug 1289824 was aiming to work around that by displaying an error message instructing people to log and and then log in again - however the error message you're seeing doesn't make that clear.
Brian, I don't suppose you could improve the UX/messaging here? :-)
Blocks: 1289824
Component: General → Treeherder
Flags: needinfo?(bstack)
Priority: -- → P1
Product: Taskcluster → Tree Management
Version: unspecified → ---
Assignee | ||
Comment 2•8 years ago
|
||
Heh, I must have missed a way this error can come to the surface. I'll take a look today to see if I can make it clearer.
Assignee: nobody → bstack
Status: NEW → ASSIGNED
Flags: needinfo?(bstack)
Comment 3•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8836784 -
Flags: review?(emorley)
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 4•8 years ago
|
||
Whoops, that's not what I meant to do.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•8 years ago
|
Attachment #8836784 -
Flags: review?(emorley) → review+
Comment 5•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/5318924e00157ac8dc76351d527a970a4f6db26f
Bug 1339041 - Fix check on error code for Taskcluster expired creds
Updated•8 years ago
|
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•