1339104 - RTCStats outbound-rtp.bytesSent is not sane

Status: RESOLVED DUPLICATE of bug 1343691

(Core :: WebRTC, defect, P1)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

outbound-rtp.bytesSent is presenting numbers like: 4840814017 in local mochitests.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1339104 - 'Make sure bytesSent, rttMs are initialized. '

Review commit: https://reviewboard.mozilla.org/r/112106/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112106/

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

It looks like rttMs was also not ensured to be initialized, though the likelihood of that was very low. webrtc.org would have to return a negative rtt.

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8836786 [details]
Bug 1339104 - 'Make sure bytesSent, rttMs are initialized. '

https://reviewboard.mozilla.org/r/112106/#review113548

::: media/webrtc/signaling/src/media-conduit/VideoConduit.cpp:803
(Diff revision 1)
>      *bytesReceived = stats.rtp_stats.MediaPayloadBytes();
>      *packetsReceived = stats.rtp_stats.transmitted.packets;
>      // Note: timestamp is not correct per the spec... should be time the rtcp
>      // was received (remote) or sent (local)
>      *timestamp = webrtc::Clock::GetRealTimeClock()->TimeInMilliseconds();
> -    int64_t rtt = mRecvStream->GetRtt();
> +    *rttMs = static_cast<int32_t>(std::max<int64_t>(mRecvStream->GetRtt(), 0));

Might be worth a comment that this sets it to zero in case of failure (-1)

::: media/webrtc/signaling/src/media-conduit/VideoConduit.cpp:823
(Diff revision 1)
>  
> -    const webrtc::VideoSendStream::Stats& stats = mSendStream->GetStats();
>      *packetsSent = 0;
> -    for (auto entry: stats.substreams){
> +    *bytesSent = 0;
> +    const webrtc::VideoSendStream::Stats& stats = mSendStream->GetStats();
> +    for (auto entry: stats.substreams) {

If you're doing whitespace changes then add a space before the : as well please.

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8836786 [details]
Bug 1339104 - 'Make sure bytesSent, rttMs are initialized. '

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112106/diff/1-2/