1339165 - Servo search results that aren't used in Quantum should be distinguished and given lower priority

Status: RESOLVED FIXED

(Webtools :: Searchfox, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

From Henri:

A search like https://searchfox.org/mozilla-central/search?q=EncodingRef
finds a bunch of stuff that is under servo/components/script/. I gather we
don't use that part of Servo in Quantum.

From Simon:




    How does one see which parts of servo/ are actually in use in Quantum?


I just came up with this:

% cargo tree --manifest-path toolkit/library/rust/Cargo.toml \
  --all-features --no-indent --all|grep -o '(.*)'|sort -u
(file:///home/simon/gecko/gfx/webrender)
(file:///home/simon/gecko/gfx/webrender_bindings)
(file:///home/simon/gecko/gfx/webrender_traits)
(file:///home/simon/gecko/media/libstagefright/binding/mp4parse)
(file:///home/simon/gecko/media/libstagefright/binding/mp4parse_capi)
(file:///home/simon/gecko/netwerk/base/rust-url-capi)
(file:///home/simon/gecko/servo/components/config)
(file:///home/simon/gecko/servo/components/geometry)
(file:///home/simon/gecko/servo/components/selectors)
(file:///home/simon/gecko/servo/components/style)
(file:///home/simon/gecko/servo/components/style/gecko_bindings/nsstring_vendor)
(file:///home/simon/gecko/servo/components/style_traits)
(file:///home/simon/gecko/servo/components/url)
(file:///home/simon/gecko/servo/ports/geckolib)
(file:///home/simon/gecko/toolkit/library/rust)
(file:///home/simon/gecko/toolkit/library/rust/shared)
(file:///home/simon/gecko/xpcom/rust/nsstring)

If I got it right, these are all the Rust crates not pulled from crates.io that can be enabled to be compiled in in libxul. I think there’s a couple more for unit tests.

(Note that "cargo tree" is separate from the rest of Cargo. You need to run "cargo install cargo-tree" and add ~/.cargo/bin to $PATH to get it.)

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Now that we do proper rust indexing, this is implcitly taken care of. Although the use of "EncodingRef" seems to have almost completely removed in the tree, you can use "Transform3D" as an example:

https://searchfox.org/mozilla-central/search?q=Transform3D&case=false&regexp=false&path=

For rust code that is actually compiled in m-c (which includes servo/components/style but excludes servo/components/layout, for example) the occurrences of "Transform3D" are shown in the Definitions/Uses at the top of the search results. The occurrences in non-compiled rust code get demoted to the "Textual Occurrences" section later on the results page.