133917 - New mail check ("biff") creates system tray icon even when "Show an alert" pref is cleared

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Skewer]

Procedure: Clear the "Show an alert" box in prefs. Have new mail arrive.

Expected: Neither the popup box nor the system tray icon show up.

Actual: System tray icon still appears.

Proposed fix: I would like to have one without the other. We should rework the
panel so that instead of saying this:

When new messages arrive:
[ ] Play a sound
[ ] Show an alert

It should do this (rearranging the boxes to fix bug 133306):

When new messages arrive alert me with:
[ ] Sound [ ] Popup message [ ] Tray icon

This way I'm not required to have both a popup and an icon if I only want one of
the two.

Build: 2002032603 WXP

Comment 1

[grylchan]

Skewer,

If 'check for new messages every' was checked and you uncheck it, 
you are correct in that the mail notification icon will still appear.
In order for it to not appear, you must exit/restart mozilla.

There is a bug filed on that already: see bug 24594.

Your other request (checkmark for sound, alert, and notificaion icon)
is an ehancement. 

I am going to mark it as a enhancement.

I am chaging subj line also.
Old subj line was : 
 New mail check ("biff") creates system tray icon even when "Show an alert" pref 
 is cleared

Comment 2

[(not reading, please use [e-mail] instead)]

the new proposed Preferences specs:

http://www.mozilla.org/mailnews/specs/mailnotify/#Prefs
http://www.mozilla.org/mailnews/specs/prefs/Preferences.html

Comment 3

[Skewer]

gchan: It looks like you modified this bug without even reading it.

I never touched the "Check for new messages every..." option. This is about the
"Show an alert" pref. In terms of correctness, NO alert should be shown as long
as this is not checked, neither the pop-up nor the tray icon. The three choices
thing was my proposed fix; however this bug is about showing a user an alert
when they asked not to receive one. The easy fix is to make that pref effect
both the pop-up and the icon.

Comment 4

[Jon Granrose]

I just ran into this one over the weekend.  On my POP account in 2003021008 on
XP, when I unchecked the "show an alert" item and restarted, I still get the
system tray icon.

I agree with the reporter.  If we're not going to change the UI, then the system
tray icon shouldn't appear if you have no biff settings set, since the tray icon
is a biff feature (we certainly didn't have it before biff landed).

Since most of my home mail is spam, until we fix biff so that it doesn't notify
on spam, I don't want any notification at all since it's distracting which is
how I ran into this bug.

Comment 5

[Mike Cowperthwaite]

*** Bug 127443 has been marked as a duplicate of this bug. ***

Comment 6

[Samir Gehani]

adt: nsbeta1-

Comment 7

[Henrik Gemal]

*** Bug 223934 has been marked as a duplicate of this bug. ***

Comment 8

[Mike Cowperthwaite]

*** Bug 228685 has been marked as a duplicate of this bug. ***

Comment 9

[Florian Effenberger]

I tried

user_pref("mail.server.default.notify.on",false);

but it has NO effect in TB 1.0.

Comment 10

[Karsten Düsterloh]

Attachment: add option for disabling the tray icon

Background patch introducing mail.biff.show_tray_icon, currently only for Win (but we may want/need that for KDE etc. in future, too), plus respective SeaMonkey UI.

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 211160 [details] [diff] [review]
add option for disabling the tray icon

Sorry for the review delay.

>-  if (!mSuppressBiffIcon)
>+  // okay, we are done showing the alert
>+  // now put an icon in the system tray, if allowed
>+  nsresult rv;
>+  nsCOMPtr<nsIPrefBranch> prefBranch(do_GetService(NS_PREFSERVICE_CONTRACTID, &rv));

How about checking rv here?

r=dmose, with that fixed.

Comment 12

[Karsten Düsterloh]

Attachment: checked-in version, updated to trunk

Checked-in version incorporating Dan's comments.

Comment 13

[Karsten Düsterloh]

Marking as fixed, since KDE tray icons don't even exist yet.

Comment 14

[Ian Neal]

What? no help patch?

Comment 15

[Karsten Düsterloh]

Attachment: /mozilla/mailnews/base/build/newmail.ico -> /mozilla/extensions/help/resources/locale/en-US/images/mail_newmail_trayicon.png

Comment 16

[Karsten Düsterloh]

Attachment: help text for tray icon pref

Comment 17

[Ian Neal]

Comment on attachment 220987 [details] [diff] [review]
help text for tray icon pref


>+  <li class="win"><strong>Show a tray icon</strong>: Select this if you want 
>+    &brandShortName; Mail &amp; Newsgroups to display an icon in your system 
>+    tray in the lower right corner of your screen when new messages arrive.
The system tray is not always at the bottom right corner so perhaps "typically" or "usually" should be inserted into the above? Also missing some punctuation. It should probably read something like "..in your system tray, which is usually in the lower right corner of your screen, when new messages arrive."

>+    The icon will stay in the system tray until you have touched all your 
>+    folders which contain new mail.
Not sure everyone would understanded "touched", is there a better way of putting it? Checked perhaps?

Comment 18

[Karsten Düsterloh]

Attachment: help text, v2

Slightly reworded and repunctuated - with commas it sounded as if the position of the tray depends upon new mail coming in...
Also corrected an error in the description of how long the icon will stay.

Comment 19

[Telmo Amaral]

>+    .... This icon will stay in the system tray until
>+    you have visited one of your folders with new mail.

Not sure this is worth mentioning in the help text, but the icon will also disappear if you manually check for new messages in the account that triggered the icon, for example by pressing F5 (unless, of course, more new messages arrive).

Comment 20

[Stephen Donner [:stephend] Not actively reading bugmail]

I've filed bug 336831.

Comment 21

[Ian Neal]

Comment on attachment 221006 [details] [diff] [review]
help text, v2

Thank you, r=me, I do not have mail coming in from multiple accounts so, if you do can you check, but either way could you see if what you have written covers comment 19?

Comment 22

[Karsten Düsterloh]

Attachment: ... or checked for new messages manually.

New version, with the 'reload behaviour' of comment #19 added.

Re commemt #21:
> I do not have mail coming in from multiple accounts

I did test the patch with parallel POP3 and IMAP, both getting new messages.

Comment 23

[Ian Neal]

Comment on attachment 221082 [details] [diff] [review]
... or checked for new messages manually.

>Index: mail_help.xhtml
>===================================================================

>+  
Nit: Don't put in spaces in empty lines.

>+  <li class="win"><strong>Show a tray icon</strong>: Select this if you want 
Nit: Don't put a space at the end of a line.

>+    &brandShortName; Mail &amp; Newsgroups to display an icon in your system
>+    tray (which is usually found in the lower right corner of your screen) when 
Nit: Remove space at end of the line.

>+    new messages arrive. This icon will stay in the system tray until you have 
Nit: Remove space at end of the line.

>+    visited one of your folders with new mail or checked for new messages manually.
Nit: Help files have a maximum 80 column width so "manually." has to go onto the next line.

>+    <p style="text-indent: 20px"><img src="images/mail_newmail_trayicon.png" alt=""/>
Nit: 80 column limit hit again, alt=""/> needs to go on the next line

>+      &nbsp;&nbsp;<strong>New mail tray icon</strong></p>
>+    <p>When the icon appears, double-clicking it will open the &brandShortName; 
Nit: Remove space at end of the line.

>+      Mail &amp; Newsgroups main window.</p>
>+  </li>
>+    
Nit: Don't put in spaces in empty lines.

Comment 24

[Karsten Düsterloh]

Attachment: checked-in help text, v4

Comment 25

[Ian Neal]

Comment on attachment 221727 [details] [diff] [review]
checked-in help text, v4

Thanks for that :-)

Comment 26

[Mike Cowperthwaite]

TB bug 283425 was about this same feature.  Now that the backend support is in place (and I've verified that it works in TB), that bug is about adding the UI for this feature to TB.

Comment 27

[Mike Cowperthwaite]

Comment on attachment 220808 [details] [diff] [review]
checked-in version, updated to trunk

Is this something worth getting in for SM 1.1/TB 2.0?

Comment 28

[Karsten Düsterloh]

I'll check that in on the branch incl. the respective regression fix in 336831 asap. 
Thanks for hunting down the a+, Mike! :)

Comment 29

[Karsten Düsterloh]

Fix and help patch checked in on MOZILLA_1_8_BRANCH.

Comment 30

[Karsten Düsterloh]

Attachment: missing image patch

Doh, I missed the icon on checkin and noone noticed...

Comment 31

[Karsten Düsterloh]

Comment on attachment 226826 [details] [diff] [review]
missing image patch

Checked in on trunk and MOZILLA_1_8_BRANCH.