Closed
Bug 1339175
Opened 7 years ago
Closed 7 years ago
Ensure that hearbeat endpoints have no-cache headers
Categories
(Conduit :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: davidwalsh, Assigned: davidwalsh)
Details
Attachments
(1 file)
Heartbeats shouldn't cache -- we must always have a realtime result.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → dwalsh
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8836835 [details] autoland: Ensure heartbeat endpoints do not cache (Bug 1339175). https://reviewboard.mozilla.org/r/112142/#review113466 ::: autoland/public-web-api/autolandweb/dockerflow.py:18 (Diff revision 2) > Since this is for load balancer checks it should not check > backing services. > """ > self.write({}) > self.set_status(200) > + self.set_header('Cache-Control', 'no-cache') You'll want to disable etag generation.
Attachment #8836835 -
Flags: review-
| Comment hidden (mozreview-request) |
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8836835 [details] autoland: Ensure heartbeat endpoints do not cache (Bug 1339175). https://reviewboard.mozilla.org/r/112142/#review114944 LGTM
Attachment #8836835 -
Flags: review?(mars) → review+
|
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8836835 [details] autoland: Ensure heartbeat endpoints do not cache (Bug 1339175). https://reviewboard.mozilla.org/r/112142/#review114968 Couple (pythonic) nits I'll take care of after landing.
Attachment #8836835 -
Flags: review+
Pushed by smacleod@mozilla.com: https://hg.mozilla.org/automation/conduit/rev/ef7c31b43d46 autoland: Ensure heartbeat endpoints do not cache . r=mars,smacleod
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•