1339204 - [EME] Test case for vp9 in MP4 work in EME

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We need a testcase for VP9 in MP4 in EME. We also need to fix a few things in the plumbing to make VP9 in MP4 actually work.

Note: This work needs to be based on Bug 1338032 and Bug 1338064.

Comment 1

[jay.harris]

Attachment: Bug 1339204 - Adds support in StageFright for VP9.0 FourCCs

Review commit: https://reviewboard.mozilla.org/r/112186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112186/

Comment 2

[jay.harris]

Attachment: Bug 1339204 - Adds VP9 and VP9.0 as supported types in the MP4Decoder

Review commit: https://reviewboard.mozilla.org/r/112188/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112188/

Comment 3

[jay.harris]

Attachment: Bug 1339204 - Adds a test for VP9 in MP4

Review commit: https://reviewboard.mozilla.org/r/112190/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112190/

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8836879 [details]
Bug 1339204 - Adds a test for VP9 in MP4

https://reviewboard.mozilla.org/r/112190/#review113464

r+, but please fix the filename.

::: dom/media/test/manifest.js:804
(Diff revision 1)
> +                    ]
> +      },
> +      {
> +          name:"audio",
> +          type:"audio/mp4; codecs=\"mp4a.40.2\"",
> +          fragments:[ "short-vp9-encrypted-audio.mp4",

The filename of this file says it's VP9, but it's actually AAC, right?

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8836877 [details]
Bug 1339204 - Adds support in StageFright for VP9.0 FourCCs

https://reviewboard.mozilla.org/r/112186/#review113468

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8836878 [details]
Bug 1339204 - Adds VP9 and VP9.0 as supported types in the MP4Decoder

https://reviewboard.mozilla.org/r/112188/#review113470

Comment 7

[jay.harris]

Comment on attachment 8836879 [details]
Bug 1339204 - Adds a test for VP9 in MP4

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112190/diff/1-2/

Comment 8

[jay.harris]

Comment on attachment 8836879 [details]
Bug 1339204 - Adds a test for VP9 in MP4

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112190/diff/2-3/

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6a72e43f25e3215b2f3956a24062164bb1bb09e
Bug 1339204 - Adds support in StageFright for VP9.0 FourCCs r=cpearce

https://hg.mozilla.org/integration/mozilla-inbound/rev/7013b268d1ab646a256ba93a2188950ff59ac748
Bug 1339204 - Adds VP9 and VP9.0 as supported types in the MP4Decoder r=cpearce

https://hg.mozilla.org/integration/mozilla-inbound/rev/8041530fb778d6d9da81af4b99a01d6ed2e4372b
Bug 1339204 - Adds a test for VP9 in MP4 r=cpearce

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b6a72e43f25e
https://hg.mozilla.org/mozilla-central/rev/7013b268d1ab
https://hg.mozilla.org/mozilla-central/rev/8041530fb778