Closed
Bug 1339232
Opened 7 years ago
Closed 7 years ago
annotate more dom/* moz.build files with BUG_COMPONENT
Categories
(Core :: DOM: Core & HTML, defect, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file, 3 obsolete files)
46.12 KB,
patch
|
overholt
:
review+
|
Details | Diff | Splinter Review |
there is still a fairly long list of dom/* directories that need annotation. $ ./mach file-info bugzilla-component dom/** UNKNOWN dom/audiochannel dom/base dom/encoding dom/events dom/fetch dom/file dom/filehandle dom/filesystem dom/grid dom/html dom/imptests dom/indexedDB dom/interfaces dom/ipc dom/jar.mn dom/json dom/jsurl dom/locales dom/manifest dom/mathml dom/messagechannel dom/moz.build dom/offline dom/performance dom/permission dom/plugins dom/power dom/presentation dom/promise dom/push dom/quota dom/res dom/secureelement dom/smil dom/svg dom/system dom/tests dom/time dom/url dom/webbrowserpersist dom/workers dom/worklet Core :: Audio/Video dom/media Core :: Canvas: 2D dom/canvas Core :: DOM dom/archivereader dom/bindings dom/broadcastchannel dom/browser-element dom/cache dom/console dom/storage dom/vr dom/webidl dom/xhr This bug will do a good portion of these.
Assignee | ||
Comment 1•7 years ago
|
||
the dom/imptests/* are imported from w3c and cover a variety of components. :ms2ger, are these replaced by web-platform-tests? I see a few webgl, typedarray, js, dom, and webapps/xhr tests- not many tests in all. If these are still useful, can you help me determine what bugzilla component these map to?
Flags: needinfo?(Ms2ger)
Assignee | ||
Comment 2•7 years ago
|
||
in dom/encoding, I see some intl/ files, I am not sure if this is Core::DOM, or Core::Internationalization, :overholt, can you help decipher this?
Flags: needinfo?(overholt)
Comment 3•7 years ago
|
||
(In reply to Joel Maher ( :jmaher) from comment #1) > the dom/imptests/* are imported from w3c and cover a variety of components. > > :ms2ger, are these replaced by web-platform-tests? I see a few webgl, > typedarray, js, dom, and webapps/xhr tests- not many tests in all. If these > are still useful, can you help me determine what bugzilla component these > map to? Note bug 1194860. Use the same components as the corresponding dirs in testing/web-platform/tests.
Flags: needinfo?(Ms2ger)
Comment 4•7 years ago
|
||
(In reply to Joel Maher ( :jmaher) from comment #2) > in dom/encoding, I see some intl/ files, I am not sure if this is Core::DOM, > or Core::Internationalization, :overholt, can you help decipher this? Henri would know better than I would.
Flags: needinfo?(overholt) → needinfo?(hsivonen)
(In reply to Andrew Overholt [:overholt] from comment #4) > (In reply to Joel Maher ( :jmaher) from comment #2) > > in dom/encoding, I see some intl/ files, I am not sure if this is Core::DOM, > > or Core::Internationalization, :overholt, can you help decipher this? > > Henri would know better than I would. I'd file dom/encoding/ bugs under Core: Internationalization.
Flags: needinfo?(hsivonen)
Assignee | ||
Comment 6•7 years ago
|
||
:ms2ger so to kill 2 birds with 1 stone, I need to figure out bug_components for: testing/web-platform/tests/typedarrays == Core::Javascript?? testing/web-platform/tests/js/builtin == ?? dom/imptests/html/html/browsers/the-window-object/ == ?? (no related dir in wpt) dom/imptests/html/dom/test_interface*.html (no related dir in wpt) dom/imptests/html/html/dom/documents/dta/test_nameditem-06.html dom/imptests/html/html/dom/elements/global-attributes/reftest*.list ?? (some magic here)
Flags: needinfo?(Ms2ger)
Assignee | ||
Comment 7•7 years ago
|
||
I got Core:: Javascript Engine for type typedarrays, the others are still pending
Comment 8•7 years ago
|
||
testing/web-platform/tests/typedarrays == Core::Javascript testing/web-platform/tests/js == Core::Javascript dom/imptests/html/html/ == Core::DOM: Core & HTML dom/imptests/html/dom/ == Core::DOM: Core & HTML
Flags: needinfo?(Ms2ger)
Comment 9•7 years ago
|
||
Actually, make that Core::Javascript: Standard Library for both.
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Comment 10•7 years ago
|
||
with this patch applied, I get: $ ./mach file-info bugzilla-component dom/** UNKNOWN dom/audiochannel dom/base dom/interfaces dom/ipc dom/jar.mn dom/json dom/jsurl dom/locales dom/manifest dom/mathml dom/messagechannel dom/moz.build dom/offline dom/performance dom/permission dom/plugins dom/power dom/presentation dom/promise dom/push dom/quota dom/res dom/secureelement dom/smil dom/svg dom/system dom/tests dom/time dom/url dom/webbrowserpersist dom/workers dom/worklet Core :: Audio/Video dom/media Core :: CSS Parsing and Computation dom/grid Core :: Canvas: 2D dom/canvas Core :: DOM dom/archivereader dom/bindings dom/broadcastchannel dom/browser-element dom/cache dom/console dom/fetch dom/file dom/filehandle dom/filesystem dom/html dom/imptests dom/storage dom/vr dom/webidl dom/xhr Core :: DOM: Animation dom/animation Core :: DOM: Device Interfaces dom/battery dom/devicestorage dom/gamepad dom/u2f dom/webauthn Core :: DOM: Events dom/events Core :: DOM: Flyweb dom/flyweb Core :: DOM: IndexedDB dom/indexedDB Core :: DOM: Security dom/crypto dom/security Core :: Embedding: APIs dom/commandhandler Core :: Geolocation dom/geolocation Core :: Internationalization dom/encoding Core :: JavaScript Engine dom/asmjscache Core :: Networking dom/network Core :: XBL dom/xbl Core :: XML dom/xml Core :: XSLT dom/xslt Core :: XUL dom/xul Toolkit :: Notifications and Alerts dom/notification
Comment 11•7 years ago
|
||
Comment on attachment 8838478 [details] [diff] [review] annotate more dom/* files with BUG_COMPONENT Review of attachment 8838478 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/imptests/moz.build @@ +10,5 @@ > +with Files("html/webgl/**"): > + BUG_COMPONENT = ("Core", "Canvas 2D") > + > +with Files("html/typedarrays/**"): > + BUG_COMPONENT = ("Core", "Javascript Engine") As I said, "Javascript: Standard Library" (twice) ::: dom/interfaces/notification/moz.build @@ +4,5 @@ > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > +with Files("**"): > + BUG_COMPONENT = ("Core", "DOM: Workers") This isn't right. Use "DOM"? ::: dom/interfaces/stylesheets/moz.build @@ +4,5 @@ > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > +with Files("**"): > + BUG_COMPONENT = ("Core", "DOM: Core & HTML") Should be "DOM: CSS Object Model" ::: dom/interfaces/xpath/moz.build @@ +4,5 @@ > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > +with Files("**"): > + BUG_COMPONENT = ("Core", "DOM") "XSLT"
Assignee | ||
Comment 12•7 years ago
|
||
thanks :ms2ger, I have updated this accordingly!
Attachment #8838478 -
Attachment is obsolete: true
Attachment #8838478 -
Flags: review?(overholt)
Attachment #8838485 -
Flags: review?(overholt)
(In reply to Joel Maher ( :jmaher) from comment #10) > dom/base Core: DOM > dom/mathml Core: MathML > dom/smil > dom/svg Core: SVG (for SMIL, too, I think) > dom/workers Core: DOM: Workers
Assignee | ||
Comment 14•7 years ago
|
||
ok, I finished dom/*, only a few resulting bugs related to not well defined/not used code.
Attachment #8838485 -
Attachment is obsolete: true
Attachment #8838485 -
Flags: review?(overholt)
Attachment #8839626 -
Flags: review?(overholt)
Comment 15•7 years ago
|
||
Comment on attachment 8839626 [details] [diff] [review] annotate the rest of dom/* files with BUG_COMPONENT Review of attachment 8839626 [details] [diff] [review]: ----------------------------------------------------------------- I still have tests/ with Files("browser/*unload*") to tests/reftests to go. ::: dom/interfaces/json/moz.build @@ +4,5 @@ > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > +with Files("**"): > + BUG_COMPONENT = ("Core", "DOM") Core::JavaScript Engine ::: dom/interfaces/smil/moz.build @@ +4,5 @@ > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > +with Files("**"): > + BUG_COMPONENT = ("Core", "DOM") Core::SVG ::: dom/ipc/moz.build @@ +4,5 @@ > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > +with Files("**"): > + BUG_COMPONENT = ("Core", "DOM") Let's confirm with billm but I *think* Core::IPC. ::: dom/json/moz.build @@ +4,5 @@ > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > +with Files("**"): > + BUG_COMPONENT = ("Core", "DOM") Core::JavaScript Engine ::: dom/jsurl/moz.build @@ +5,5 @@ > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > +with Files("**"): > + BUG_COMPONENT = ("Core", "DOM") > + Core::Document Navigation ::: dom/locales/moz.build @@ +10,5 @@ > +with Files("en-US/chrome/accessibility/**"): > + BUG_COMPONENT = ("Core", "Disability Access APIs") > + > +with Files("en-US/chrome/dom/**"): > + BUG_COMPONENT = ("Core", "Web Audio") Probably Core::DOM:Core & HTML or Core::DOM but there are many components covered. @@ +14,5 @@ > + BUG_COMPONENT = ("Core", "Web Audio") > + > +# looks like many possible components here > +with Files("en-US/chrome/layout/**"): > + BUG_COMPONENT = ("Core", "DOM") Yeah ... ::: dom/quota/moz.build @@ +5,5 @@ > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > + > +with Files("**"): > + BUG_COMPONENT = ("Core", "DOM: IndexedDB") We have a DOM:Quota Manager component as of bug 1339528 :) ::: dom/secureelement/moz.build @@ +7,5 @@ > > +# All of this seems to be FirefoxOS::NFC > +with Files("**"): > + BUG_COMPONENT = ("Core", "DOM") > + Could be DOM:Device Interfaces if all related to NFC-implementation. ::: dom/system/moz.build @@ +4,5 @@ > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > +# This picks up *hapticfeedback* which is graveyard > +# This picks up gonk/* which is also not supported? I think you're right that gonk ended up as Tier 3 (or not?). ::: dom/tests/moz.build @@ +10,5 @@ > +with Files("browser/*onsole*"): > + BUG_COMPONENT = ("Firefox", "Developer Tools") > + > +with Files("browser/*autofocus*"): > + BUG_COMPONENT = ("Core", "DOM: Core * HTML") Core & HTML (not "Core * HTML") @@ +132,5 @@ > +with Files("reftest/xml-stylesheet/**"): > + BUG_COMPONENT = ("Core", "XSLT") > + > +with Files("unit/**"): > + BUG_COMPONENT = ("Core", "DOM") unit/test_bug465752.js is Core::CSS Parsing and Computation
Assignee | ||
Comment 16•7 years ago
|
||
addressed all changes so far, still have a few more for you to review and to: 1) ask :billm about dom/ipc 2) look at dom/locale/en-US/chrome/layout/**, there are 9 files there - should I try to assign those to specific components?
Attachment #8839626 -
Attachment is obsolete: true
Attachment #8839626 -
Flags: review?(overholt)
Attachment #8841570 -
Flags: review?(overholt)
Assignee | ||
Comment 17•7 years ago
|
||
:billm, could you help me figure out which bugzilla component the dom/ipc/* files belong to: https://dxr.mozilla.org/mozilla-central/source/dom/ipc possibly Core::IPC, or another general one? If there are specific files that belong elsewhere, I am happy to get more granular.
Flags: needinfo?(wmccloskey)
(In reply to Joel Maher ( :jmaher) from comment #17) > :billm, could you help me figure out which bugzilla component the dom/ipc/* > files belong to: > https://dxr.mozilla.org/mozilla-central/source/dom/ipc DOM::Content Processes is probably the right component for that directory.
Flags: needinfo?(wmccloskey)
Comment 19•7 years ago
|
||
Comment on attachment 8841570 [details] [diff] [review] annotate the rest of dom/* files with BUG_COMPONENT Review of attachment 8841570 [details] [diff] [review]: ----------------------------------------------------------------- I'm sorry for the unacceptable delay here. There are a few minor changes (thanks for making the others!) and with them r+. ::: dom/tests/moz.build @@ +25,5 @@ > +with Files("browser/*geo_*"): > + BUG_COMPONENT = ("Core", "Geolocation") > + > +with Files("browser/browser_cancel_keydown_keypress_event.js"): > + BUG_COMPONENT = ("Core", "DOM: Events") Core::Event Handling seems better (but the distinction between DOM: Events and Core::Event Handling is sometimes ambiguous). @@ +28,5 @@ > +with Files("browser/browser_cancel_keydown_keypress_event.js"): > + BUG_COMPONENT = ("Core", "DOM: Events") > + > +with Files("browser/*local*"): > + BUG_COMPONENT = ("Core", "DOM: Content Processes") These are probably better off in Core:: DOM since localStorage+e10s should be the norm in the future (and thus less-specific to separate content processes). @@ +34,5 @@ > +with Files("browser/*prerender*"): > + BUG_COMPONENT = ("Core", "Document Navigation") > + > +with Files("browser/browser_test_focus_after_modal_state.js"): > + BUG_COMPONENT = ("Core", "DOM: Events") Core:: Event Handling (see above for wishy-washy justification) @@ +37,5 @@ > +with Files("browser/browser_test_focus_after_modal_state.js"): > + BUG_COMPONENT = ("Core", "DOM: Events") > + > +with Files("mochitest/ajax/**"): > + BUG_COMPONENT = ("Testing", "Mochitest") (Some of?) these are test suites we imported (sometimes long) ago. If you're ok with them being in Mochitest that's probably easiest. @@ +45,5 @@ > + > +with Files("mochitest/beacon/**"): > + BUG_COMPONENT = ("Core", "DOM") > + > +# big mix of components here Yep :) @@ +72,5 @@ > +with Files("mochitest/fetch/**"): > + BUG_COMPONENT = ("Core", "DOM") > + > +with Files("mochitest/gamepad/**"): > + BUG_COMPONENT = ("Core", "DOM") Let's use Core:: DOM: Device Interfaces for Gamepad API stuff. @@ +74,5 @@ > + > +with Files("mochitest/gamepad/**"): > + BUG_COMPONENT = ("Core", "DOM") > + > +with Files("mochitest/general/**"): Another mix of components here but DOM is fine as a starting point for most of them. @@ +78,5 @@ > +with Files("mochitest/general/**"): > + BUG_COMPONENT = ("Core", "DOM") > + > +with Files("mochitest/geolocation/**"): > + BUG_COMPONENT = ("Core", "Geolocaiton") Typo here s/Geolocaiton/Geolocation/ @@ +87,5 @@ > +with Files("mochitest/notification/**"): > + BUG_COMPONENT = ("Core", "DOM") > + > +with Files("mochitest/orientation/**"): > + BUG_COMPONENT = ("Core", "Layout: Images") This is true for *bug507092* but in general orientation things should probably go in Core:: DOM: Device Interfaces.
Attachment #8841570 -
Flags: review?(overholt) → review+
Comment 20•7 years ago
|
||
(In reply to Joel Maher ( :jmaher) from comment #16) > 2) look at dom/locale/en-US/chrome/layout/**, there are 9 files there - > should I try to assign those to specific components? It is a mix ... css.properties -> while not entirely accurate, Core::CSS Parsing and Computation is probably OK as a default htmlparser.properties -> Core::HTML: Parser layout_errors.properties -> seems most of the strings belong to Core::DOM: Animation HtmlForm.properties MediaDocument.properties -> messy ... let's go with Core::Layout: Images printing.properties -> despite a number of changes being done in XPCOM, let's go with Core::Printing: Output xbl.properties -> probably easiest to default to Core::XBL xmlparser.properties -> Core::XML xul.properties -> another messy one; let's go with Core::XUL as the default
Comment 21•7 years ago
|
||
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c7ab28e72242 annotate more dom/* moz.build files with BUG_COMPONENT. r=overholt
Comment 22•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c7ab28e72242
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•