Closed Bug 1339240 Opened 3 years ago Closed 3 years ago

make artifact builds work with git worktree

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: tromey, Assigned: glandium)

Details

Attachments

(1 file)

I tried an artifact build today using a git worktree, and it failed.
Eventually I found the fine print in https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds :

Git worktrees are not supported with artifact builds, but an easy workaround is to use git-new-workdir for a similar feature.

I think it would be useful to support git worktrees.
Assignee: nobody → mh+mozilla
Comment on attachment 8839345 [details]
Bug 1339240 - Detect git worktrees in MachCommandConditions.is_git.

https://reviewboard.mozilla.org/r/114014/#review115708
Attachment #8839345 - Flags: review?(cmanchester) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/b26e27c14e49
Detect git worktrees in MachCommandConditions.is_git. r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/b26e27c14e49
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
FYI, I updated MDN.
Thank you for doing this.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.