1339351 - Fix a typo in background_video.js

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

http://searchfox.org/mozilla-central/rev/d3307f19d5dac31d7d36fc206b00b686de82eee4/dom/media/test/background_video.js#54

It should be |Promise.resolve()| instead of |Promise.success()|. This might account for timeouts in dom/media/test/test_background_video_*.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1339351 - fix typo.

Review commit: https://reviewboard.mozilla.org/r/112326/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112326/

Comment 2

[Tzuhao Kuo [:kaku]]

Comment on attachment 8837054 [details]
Bug 1339351 - fix typo.

https://reviewboard.mozilla.org/r/112326/#review113956

This is cool..., Promise.success() is even not a real API, right?

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Yeah. I can't find such an API in any documents...
Thanks for the review.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a776b907e01
fix typo. r=kaku

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8837054 [details]
Bug 1339351 - fix typo.

Approval Request Comment
[Feature/Bug causing the regression]:1284177 
[User impact if declined]:mochitest timeout
[Is this code covered by automated tests?]:yes
[Has the fix been verified in Nightly?]:yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:none
[Is the change risky?]:no
[Why is the change risky/not risky?]:this is a simple one-line change.
[String changes made/needed]:none

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3a776b907e01

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8837054 [details]
Bug 1339351 - fix typo.

Fix a mochitest timeout error. Aurora53+.

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 8837054 [details]
Bug 1339351 - fix typo.

test-only change

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9cde62d9b944

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/23b6c61a0088

Comment 11

[Andrei Vaida [:avaida]]

Setting qe-verify- based on JW Wang's assessment on manual testing needs (Comment 5) and the fact that this fix has automated coverage.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/23b6c61a0088