Closed Bug 1339351 Opened 4 years ago Closed 4 years ago
Fix a typo in background
http://searchfox.org/mozilla-central/rev/d3307f19d5dac31d7d36fc206b00b686de82eee4/dom/media/test/background_video.js#54 It should be |Promise.resolve()| instead of |Promise.success()|. This might account for timeouts in dom/media/test/test_background_video_*.
Assignee: nobody → jwwang
Depends on: 1284177
Priority: -- → P3
Comment on attachment 8837054 [details] Bug 1339351 - fix typo. https://reviewboard.mozilla.org/r/112326/#review113956 This is cool..., Promise.success() is even not a real API, right?
Attachment #8837054 - Flags: review?(kaku) → review+
Yeah. I can't find such an API in any documents... Thanks for the review.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/3a776b907e01 fix typo. r=kaku
Comment on attachment 8837054 [details] Bug 1339351 - fix typo. Approval Request Comment [Feature/Bug causing the regression]:1284177 [User impact if declined]:mochitest timeout [Is this code covered by automated tests?]:yes [Has the fix been verified in Nightly?]:yes [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]:none [Is the change risky?]:no [Why is the change risky/not risky?]:this is a simple one-line change. [String changes made/needed]:none
Comment on attachment 8837054 [details] Bug 1339351 - fix typo. Fix a mochitest timeout error. Aurora53+.
Attachment #8837054 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8837054 [details] Bug 1339351 - fix typo. test-only change
Attachment #8837054 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Setting qe-verify- based on JW Wang's assessment on manual testing needs (Comment 5) and the fact that this fix has automated coverage.
You need to log in before you can comment on or make changes to this bug.