1339393 - Remove IndexedDBPromptHelper dead code

Status: RESOLVED INVALID

(Firefox :: General, defect)

Description

[Florian Quèze [:florian]]

This is dead code since bug 994190 removed the platform code sending the indexedDB-permissions-prompt notification.

There's similar code using the same strings and the same notification anchor icon at http://searchfox.org/mozilla-central/rev/d3307f19d5dac31d7d36fc206b00b686de82eee4/browser/base/content/browser.js#6090
That code is used.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

For mobile/ the equivalent code that's still in use is in mobile/android/chrome/content/OfflineApps.js

Comment 2

[Florian Quèze [:florian]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=12077c61d682

Comment 3

[:Gijs (he/him)]

Comment on attachment 8837107 [details] [diff] [review]
Patch

I don't think this is dead:

https://dxr.mozilla.org/mozilla-central/source/dom/indexedDB/PermissionRequestBase.cpp#155-157

though tbh, that best be happening in the parent process or this doesn't work with e10s enabled.

Comment 4

[Florian Quèze [:florian]]

This makes it really hard to find :-(

#define IDB_PREFIX "indexedDB"
#define TOPIC_PREFIX IDB_PREFIX "-permissions-"
const char kPermissionPromptTopic[] = TOPIC_PREFIX "prompt";

Glad we have code review!

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

(In reply to :Gijs from comment #3)
> though tbh, that best be happening in the parent process or this doesn't
> work with e10s enabled.

The call-sites to PermissionRequestBase::PromptIfNeeded are gated on an XRE_IsParentProcess() check.  If they're not already in the parent process, they do (IPC) TabChild::SendPIndexedDBPermissionRequestConstructor(...).