Closed
Bug 1339401
Opened 7 years ago
Closed 7 years ago
Remove browser/base/content/aboutaccounts/images/fox.png
Categories
(Firefox :: Sync, defect, P3)
Tracking
()
RESOLVED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: florian, Unassigned, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [bugday-20170426])
Attachments
(1 file, 2 obsolete files)
chrome://browser/content/aboutaccounts/images/fox.png is flagged as unused by my test in bug 1316187. This file was added in bug 965117, but I can't find any use of it (neither at the time, nor now).
Comment 1•7 years ago
|
||
This got added in bug 957425 and used as background image: https://hg.mozilla.org/mozilla-central/rev/d81113054e13#l11.39 Its use got removed in bug 972061: https://hg.mozilla.org/mozilla-central/rev/1bea2a295c8a Both changesets landed for Gecko 29.
Updated•7 years ago
|
Mentor: eoger
Keywords: good-first-bug
Updated•7 years ago
|
Priority: -- → P3
Comment 2•7 years ago
|
||
I would like to work on this bug. Is this as simple as removing the fox.png file in the specified location?
Updated•7 years ago
|
Flags: needinfo?(eoger)
Comment 3•7 years ago
|
||
Hello Srivatsav, In addition to removing the file, you'll have to remove its references. I counted only one here: https://dxr.mozilla.org/mozilla-central/source/browser/base/jar.mn#55 This should be fairly simple.
Flags: needinfo?(eoger)
Comment 4•7 years ago
|
||
Yeah, actually I searching for the location of that jar.mn. Thanks for the link. I have removed those lines. Please review it.
Attachment #8842302 -
Flags: review?(eoger)
Comment 5•7 years ago
|
||
Comment on attachment 8842302 [details] [diff] [review] bug-1339401-fix-v2.patch Review of attachment 8842302 [details] [diff] [review]: ----------------------------------------------------------------- Awesome, please change the commit message to something like Bug 1339401 - Remove unused fox.png image. r=eoger And I'll land it tomorrow. Thanks!
Attachment #8842302 -
Flags: review?(eoger)
Comment 6•7 years ago
|
||
I have updated the commit message
Attachment #8842302 -
Attachment is obsolete: true
Attachment #8842559 -
Flags: review?(eoger)
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8842582 [details] Bug 1339401: Remove unused fox.png image. https://reviewboard.mozilla.org/r/116372/#review117978
Attachment #8842582 -
Flags: review?(eoger) → review+
Updated•7 years ago
|
Attachment #8842559 -
Attachment is obsolete: true
Attachment #8842559 -
Flags: review?(eoger)
Pushed by eoger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1d8bb95f9eb0 Remove unused fox.png image. r=eoger
Comment 10•7 years ago
|
||
Thank you Srivatsav
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1d8bb95f9eb0
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment 12•7 years ago
|
||
I have reproduced this on Firefox Nightly according to (2017-02-14) Fixing bug is verified on Latest Developer Edition-- Build ID:(20170427004028),User Agent: Mozilla/5.0 (Windows NT 6.1; rv:54.0) Gecko/20100101 Firefox/54.0 Tested OS-- Windows7 32bit [bugday-20170426]
Updated•7 years ago
|
Whiteboard: [bugday-20170426]
You need to log in
before you can comment on or make changes to this bug.
Description
•