1339406 - Remove Rhino specific functions from jstest harness

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[André Bargull [:anba]]

And additionally check for other possible removals or changes, so I don't need to create a new bug report all the time.

Comment 1

[André Bargull [:anba]]

Attachment: bug1339406-part1-remove-rhino.patch

Removes Rhino specific functions from jstest harness.

Rhino is basically unmaintained and it doesn't actually use our current jstest tests, so it's okay to remove these functions.

Comment 2

[André Bargull [:anba]]

Attachment: bug1339406-part2-add-var-for-local.patch

Only adds two missing 'var's for local variables.

Comment 3

[André Bargull [:anba]]

Attachment: bug1339406-part3-strict-mode-iife.patch

Enables strict mode for the IIFEs in the top-level shell.js and browser.js files.

Comment 4

[André Bargull [:anba]]

Attachment: bug1339406-part4-remove-methodjit-opt-test.patch

MethodJIT is no longer present and so are its shell options.

Comment 5

[André Bargull [:anba]]

Attachment: bug1339406-part5-remove-unused-shell-functions.patch

This removes unused functions from various shell.js files. The largest changes are in ecma_3/Date/shell.js, but that file was more or less an outdated version of ecma/shell.js!

Comment 6

[André Bargull [:anba]]

Attachment: bug1339406-part6-block-scope-vars.patch

It almost looks like the helper variables were supposed to be block-scoped, because they're nested in a block statement.

Comment 7

[André Bargull [:anba]]

Attachment: bug1339406-part7-remove-tracemonkey-tests.patch

This updates or removes tests specific to TraceMonkey.

Comment 8

[Tooru Fujisawa [:arai]]

Comment on attachment 8837212 [details] [diff] [review]
bug1339406-part7-remove-tracemonkey-tests.patch

Review of attachment 8837212 [details] [diff] [review]:
-----------------------------------------------------------------

Great :D

::: js/src/tests/js1_8_1/jit/math-jit-tests.js
@@ +81,3 @@
>    print(desc, ": FAILED: expected", typeof(expected), 
>          "(", uneval(expected), ")",
> +        "",

this line can just be removed.

@@ +84,3 @@
>          "!= actual",
>          typeof(actual), "(", uneval(actual), ")",
> +        "");

also this is unnecessary, but feel free to keep it there or ");" part there to reduce the diff.

Comment 9

[André Bargull [:anba]]

Attachment: bug1339406-part7-remove-tracemonkey-tests.patch

Update part 7 per review comments, carrying r+.

Comment 10

[André Bargull [:anba]]

(In reply to Tooru Fujisawa [:arai] from comment #8)
> also this is unnecessary, but feel free to keep it there or ");" part there
> to reduce the diff.

I've removed both empty strings, because I don't think it's too crucial to keep the diff minimal for these changes. :-)

Comment 11

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7270f79226b632faa0f9678517f13ee956ce4708

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cce05a2b6308
Part 1: Remove Rhino specific functions from jstest harness. r=arai
https://hg.mozilla.org/integration/mozilla-inbound/rev/f34ed6a5b9ca
Part 2: Add missing 'var' declarations for local variables in jstest harness functions. r=arai
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb11e452585a
Part 3: Change top-level shell.js and browser.js IIFE to strict mode. r=arai
https://hg.mozilla.org/integration/mozilla-inbound/rev/509ba75cce2b
Part 4: Remove tests for methodjit shell options. r=arai
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5f655086e0c
Part 5: Remove unused functions from shell.js files. r=arai
https://hg.mozilla.org/integration/mozilla-inbound/rev/8de9955bf062
Part 6: Block-scope helper variables from ecma_6/Math/shell.js. r=arai
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a7b08f075ac
Part 7: Remove tests for tracemonkey options from jstests. r=arai

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cce05a2b6308
https://hg.mozilla.org/mozilla-central/rev/f34ed6a5b9ca
https://hg.mozilla.org/mozilla-central/rev/fb11e452585a
https://hg.mozilla.org/mozilla-central/rev/509ba75cce2b
https://hg.mozilla.org/mozilla-central/rev/c5f655086e0c
https://hg.mozilla.org/mozilla-central/rev/8de9955bf062
https://hg.mozilla.org/mozilla-central/rev/9a7b08f075ac