1339409 - "mach bootstrap" for artifact desktop builds fails due to "FileNotFoundError" in install_rustup()

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I tried to run "mach bootstrap" on a Windows8 loaner machine via mozilla-build and the command failed as follows:

NameError: global name 'FileNotFoundError' is not defined

  File "c:\builds\mozilla-unified\python/mozboot/mozboot/mach_commands.py", line
 26, in bootstrap
    bootstrapper.bootstrap()
  File "c:\builds\mozilla-unified\python/mozboot\mozboot\bootstrap.py", line 223
, in bootstrap
    self.instance.install_system_packages()
  File "c:\builds\mozilla-unified\python/mozboot\mozboot\mozillabuild.py", line
22, in install_system_packages
    self.install_rustup()
  File "c:\builds\mozilla-unified\python/mozboot\mozboot\mozillabuild.py", line
48, in install_rustup
    except FileNotFoundError:

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1339409 - mozboot: Fix undefined FileNotFoundError.

The FileNotFoundError built-in exception is only present in
python 3. Emulate its behaviour in python 2 with a conditional
OSError.

Review commit: https://reviewboard.mozilla.org/r/112450/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112450/

Comment 2

[Ralph Giles (:rillian)]

oops, thought I'd fixed. Of course if you got this error it means the install probably also failed?

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8837281 [details]
Bug 1339409 - mozboot: Fix undefined FileNotFoundError.

https://reviewboard.mozilla.org/r/112450/#review113848

r=me.  WDYT about the below change?

::: python/mozboot/mozboot/mozillabuild.py:49
(Diff revision 1)
> -            except FileNotFoundError:
> +            except OSError as e:
> +                # Emulate FileNotFoundError on python 2.
> +                if e.errno == errno.ENOENT:

I think we could just remove the comment.  I wondered what would happen in Python 3 with this code--as future readers might--and discovered `FileNotFoundError` was a subclass of `OSError`.  Talking about emulation in this context is just a historical artifact of the code, IMHO.

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8837281 [details]
Bug 1339409 - mozboot: Fix undefined FileNotFoundError.

https://reviewboard.mozilla.org/r/112450/#review113854

::: python/mozboot/mozboot/mozillabuild.py:49
(Diff revision 1)
> -            except FileNotFoundError:
> +            except OSError as e:
> +                # Emulate FileNotFoundError on python 2.
> +                if e.errno == errno.ENOENT:

According the the requests, module, FileNotFoundError is a subclass of OSError, and so this clause will pass that as well. This seems to work in a test script I tried.

This is what I was trying to indicate with the comment, apparently unsuccessfully. I don't think it's worth writing out the whole thing just for potential python3 porting, so I'll just remove the comment.

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8837281 [details]
Bug 1339409 - mozboot: Fix undefined FileNotFoundError.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112450/diff/1-2/

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8837281 [details]
Bug 1339409 - mozboot: Fix undefined FileNotFoundError.

https://reviewboard.mozilla.org/r/112450/#review113856

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4dd3c6bf5b29
mozboot: Fix undefined FileNotFoundError. r=froydnj

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Ralph Giles (:rillian) | needinfo me from comment #2)
> oops, thought I'd fixed. Of course if you got this error it means the
> install probably also failed?

Most likely yes. But not sure what it actually was because of the busted stack output.

Thanks for fixing this problem.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4dd3c6bf5b29

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Now I also know the underlying issue... for details see bug 1339347 comment 5.

Comment 11

[Ralph Giles (:rillian)]

Ah, python too old for tls does explain it. :/