Remove unused chrome://branding/content/icon128.png file

RESOLVED WONTFIX

Status

()

Firefox
General
RESOLVED WONTFIX
a year ago
8 months ago

People

(Reporter: florian, Assigned: Dan Banner)

Tracking

53 Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
chrome://branding/content/icon128.png is flagged as unused by my test in bug 1316187. This file was added in bug 750106, but doesn't seem to be used anymore.
At some point it was used by the control center, but that was removed at https://hg.mozilla.org/mozilla-central/rev/fde6d2f7d6bc#l12.117

Note: it's listed as a duplicate of browser/icons/mozicon128.png in browser/installer/allowed-dupes.mn
Comment hidden (mozreview-request)
(Assignee)

Updated

8 months ago
Assignee: nobody → dbugs

Comment 2

8 months ago
mozreview-review
Comment on attachment 8900715 [details]
Bug 1339420 - Remove references to unused chrome://branding/content/icon128.png

https://reviewboard.mozilla.org/r/172160/#review178944

we should remove icon files in browser/branding/xxx/mozicon128.png as well

Comment 3

8 months ago
We'll need icon128/mozicon128 in bug 1392468 to provid 2x size of the overlay notification icon.

Since there's a new dependency, should we still remove these icons?
Flags: needinfo?(ehung)
(In reply to Fred Lin [:gasolin] from comment #2)
> Comment on attachment 8900715 [details]
> Bug 1339420 - Remove references to unused
> chrome://branding/content/icon128.png
> 
> https://reviewboard.mozilla.org/r/172160/#review178944
> 
> we should remove icon files in browser/branding/xxx/mozicon128.png as well

I wasn't convinced when looking at this. The icon is packaged separately here:

http://searchfox.org/mozilla-central/rev/cd82cacec2cf734768827ff85ba2dba90a534c5e/browser/branding/branding-common.mozbuild#49

iirc, I've seen comments in the past that at least some Linux distros use it, or that there have been some references pointing people to use it as a desktop icon.

Hence we went for the safer option of removing the clearly unused chrome references to it.
(Reporter)

Comment 5

8 months ago
mozreview-review
Comment on attachment 8900715 [details]
Bug 1339420 - Remove references to unused chrome://branding/content/icon128.png

https://reviewboard.mozilla.org/r/172160/#review179000

r+ because the patch looks good, but as pointed out in comment 3, this seems to be in direct conflict with the patch from bug 1392468, so we may end up wontfixing this bug.
Attachment #8900715 - Flags: review?(florian) → review+

Comment 6

8 months ago
since icon128 has new dependency now, set this issue as wontfix
Blocks: 1392468
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Flags: needinfo?(ehung)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.