1339435 - Threading assertion failure in profiler_time(const mozilla::TimeStamp& aTime)

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Julian Seward [:jseward]]

This ..

  double
  profiler_time(const mozilla::TimeStamp& aTime)
  {
    MOZ_RELEASE_ASSERT(NS_IsMainThread());

.. fails.  It was seen running on "Thread 26 DOM Worker".

I had trouble capturing a stack with GDB -- it froze up my desktop --
but finally it crashed in valgrind.  Details in the attachment.

Comment 1

[Julian Seward [:jseward]]

Attachment: Crash stack, etc

Comment 2

[Julian Seward [:jseward]]

STR: I am not sure if all of the following are really necessary,
but anyway:

1. Build on Linux with assertions enabled.

2. Start the build and disable e10s [probably not required]

3. Restart.  Click on the profiler's button, then "Settings"
   and change the text in the Threads box to 
   "GeckoMain,Compositor,_,Stream"
   [I don't know whether this is necessary.]

4. Click on "Apply (Restart Profiler)"

5. "Generally use" the profiler for a couple of minutes (start, stop,
   view profile, browse).  It crashes pretty quickly.

Comment 3

[Julian Seward [:jseward]]

Attachment: Another crash stack, this time from GDB

Comment 4

[Julian Seward [:jseward]]

Hmm, that's a MOZ_RELEASE_ASSERT, so maybe --enable-debug isn't needed.

Comment 5

[Nicholas Nethercote [inactive]]

Thank you for the report. When I added those assertions, I just stuck them everywhere and then removed the ones that triggered during local execution and a try push. So clearly that was insufficient coverage. It's trivial to remove them; patch coming up shortly.

Comment 6

[Nicholas Nethercote [inactive]]

Attachment: Fix bogus assertion in both profiler_time() variants

Comment 7

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f0f27caeb444fc0871bc8e4bb9872391f872cc59
Bug 1339435 - Fix bogus assertion in both profiler_time() variants. r=jseward.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f0f27caeb444