Closed Bug 1339444 Opened 5 years ago Closed 5 years ago

Remove unused resource://gre/modules/sqlite/sqlite_internal.js

Categories

(Toolkit :: Storage, defect)

Product:
Toolkit
Component:
Storage
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

Patch
22.56 KB, patch
Yoric
: review+
Details | Diff | Splinter Review 
My test in bug 1316187 reports resource://gre/modules/sqlite/sqlite_internal.js as unreferenced. Is this dead code we should remove? I see it has been added in bug 853439, but I don't see any caller for it, neither in the tree, nor on https://dxr.mozilla.org/addons/
Flags: needinfo?(dteller)
If we decide to remove this, we should wontfix bug 853438.
We don't have short term plans to make use of this, atm. It may be useful to keep it around as a reference, but it may even just be pointless for a long time.
See Also: → 853438
Yeah, let's remove it.
Flags: needinfo?(dteller)
Assignee: nobody → florian
Summary: resource://gre/modules/sqlite/sqlite_internal.js is unused → Remove unused resource://gre/modules/sqlite/sqlite_internal.js
Attached patch Patch — — Splinter Review
Attachment #8837644 - Flags: review?(dteller)
Attachment #8837644 - Flags: review?(dteller) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/09ca7a2cc13a3f6181095d23d27daabe3422d857
Bug 1339444 - Remove unused resource://gre/modules/sqlite/sqlite_internal.js, r=Yoric.
https://hg.mozilla.org/mozilla-central/rev/09ca7a2cc13a
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.