1339549 - failure to run mach taskgraph optimized due to check_servo key

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

$ ./mach taskgraph optimized -p parameters.yml
Traceback (most recent call last):
  File "c:\Users\elvis\mozilla-inbound\taskcluster/mach_commands.py", line 343, in show_taskgraph
    parameters=parameters)
  File "c:\Users\elvis\mozilla-inbound\taskcluster\taskgraph\generator.py", line 86, in __init__
    self.filters = [filter_tasks.filter_task_functions[f] for f in filters]
KeyError: 'check_servo'

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

adding this block in locally helps:
https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/filter_tasks.py#41

I have an up to date mozilla-inbound tree, confused why this is the case.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

If that block is not present in your working copy then this is isn't a taskcluster bug :)

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

it appears this really old parameters.yml I was using (from about 10 days ago) is the problem?  I downloaded new parameters.yml from autoland, inbound, and m-c and it works.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

I ran into this again, using a parameters.yml from try server yields this, despite a fully up to date source tree.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: parameters.yml

this is the parameters.yml that results in the error:

$ ./mach taskgraph optimized -p parameters.yml
Traceback (most recent call last):
  File "c:\Users\elvis\mozilla-inbound\taskcluster/mach_commands.py", line 343, in show_taskgraph
    parameters=parameters)
  File "c:\Users\elvis\mozilla-inbound\taskcluster\taskgraph\generator.py", line 86, in __init__
    self.filters = [filter_tasks.filter_task_functions[f] for f in filters]
KeyError: 'check_servo'

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

oh, there is a 'check_servo' in the filters section of parameters.yml- and seems to be specific to that parameters.yml, I suspect it comes from the branch of the committer, I don't see this on all parameters.yml though.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

I ran into it yesterday, too.  I think something had just landed when you made comment 1, and wasn't reflected in dxr yet, henc the confusion.

Just removing `check_servo` from parameters.yml, or grabbing a new one from central, will fix it up.

Specifically, I think it was
  https://hg.mozilla.org/mozilla-central/rev/4db2b9c21878
which was pushed to central on the 12th.