1339621 - Directly add default null collation to available collations list

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, defect)

Description

[André Bargull [:anba]]

This avoids the Array.prototype.unshift call collatorSortLocaleData. 

When I was running the sessionrestore_no_auto_restore and ts_paint Talos tests locally to test if any array fails to use the Array.prototype.unshift optimization (bug 1337119, bug 1323782), I found out that the optimization fails for the collations array. (This was even the only array for which this optimization failed!)

Comment 1

[André Bargull [:anba]]

Attachment: bug1339621.patch

Removes the unshift() call by directly placing |null| at the correct position in the collations array.

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8837349 [details] [diff] [review]
bug1339621.patch

Review of attachment 8837349 [details] [diff] [review]:
-----------------------------------------------------------------

I never did like that null-shifting, but I never found the time to actually justify the cleanup.

Comment 3

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8f68ef78915c4926b81b6f0f6b8ab5c1f068843

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/edf262601235
Directly add default null collation instead of shifting all elements with unshift(). r=Waldo

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/edf262601235