1339635 - pingsender fails to build on Tier3 platforms

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Jan Beich]

$ ./mach build
[...]
Unified_cpp_pingsender0.o: In function `main':
toolkit/components/telemetry/pingsender/Unified_cpp_pingsender0.cpp:(.text.main+0x130): undefined reference to `PingSender::Post(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)'
/usr/bin/ld: Unified_cpp_pingsender0.o: relocation R_X86_64_PC32 against `_ZN10PingSender4PostERKNSt3__112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEES8_' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value

Comment 1

[Jan Beich]

After bug 969757 there's no more support for non-Unix systems besides Windows.

Comment 2

[Jan Beich]

Attachment: Bug 1339635 - Unbreak build on Tier3 platforms after bug 1310703.

Review commit: https://reviewboard.mozilla.org/r/112508/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112508/

Comment 3

[Jan Beich]

Comment on attachment 8837357 [details]
Bug 1339635 - Unbreak build on Tier3 platforms after bug 1310703.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112508/diff/1-2/

Comment 4

[Jan Beich]

Comment on attachment 8837357 [details]
Bug 1339635 - Unbreak build on Tier3 platforms after bug 1310703.

https://reviewboard.mozilla.org/r/112508/#review113926

::: toolkit/components/telemetry/pingsender/moz.build:24
(Diff revision 2)
>      UNIFIED_SOURCES += [
>          'pingsender_win.cpp',
>      ]
> -elif CONFIG['OS_ARCH'] == 'Darwin' or CONFIG['OS_ARCH'] == 'Linux':
> +
> +    OS_LIBS += [
> +        'wininet',

Only pigsender_win.cpp uses wininet.dll. I don't think we support `OS_ARCH != OS_TARGET` on Windows, even less WINNT/Android. ;)

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 8837357 [details]
Bug 1339635 - Unbreak build on Tier3 platforms after bug 1310703.

https://reviewboard.mozilla.org/r/112508/#review114596

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92756fb365fa
Unbreak build on Tier3 platforms after bug 1310703. r=ted

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/92756fb365fa