Closed Bug 1339668 Opened 3 years ago Closed 3 years ago

Show account creation rows correctly in Account Central for a new profile

Categories

(MailNews Core :: Account Manager, defect)

defect
Not set

Tracking

(thunderbird52 fixed, thunderbird53 fixed, thunderbird54 fixed)

RESOLVED FIXED
Thunderbird 54.0
Tracking Status
thunderbird52 --- fixed
thunderbird53 --- fixed
thunderbird54 --- fixed

People

(Reporter: alta88, Assigned: alta88)

Details

Attachments

(1 file)

On a brand new profile, the Create a new account: row is not shown. Also, the locked pref forgot the CreateAccounts row.

If for some reason the account creation pref is locked and there aren't any accounts, then probably the rows should be shown otherwise it's a rather dead profile.
Assignee: nobody → alta88
Attachment #8837390 - Flags: review?(acelists)
Comment on attachment 8837390 [details] [diff] [review]
accountcentral.patch

Review of attachment 8837390 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, "Create a new account:" and "Accounts" rows are shown now.

Also it seems you now properly hide the CreateAccounts row when the pref is locked? I agree with that.
The profile may appear "dead" but the admin of it may have other plans with it. If he decided to not allow creating accounts, do not allow it via some ways.
Attachment #8837390 - Flags: review?(acelists) → review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
OS: Unspecified → All
Hardware: Unspecified → All
Version: unspecified → Trunk
https://hg.mozilla.org/comm-central/rev/1d004608b57f98aab13e93a31b874879210302a7
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 54.0
Comment on attachment 8837390 [details] [diff] [review]
accountcentral.patch


requesting uplift, since the first thing a new user looks at should be great. zero risk, and fixes a locked account being not actually locked for account manager windows.
Attachment #8837390 - Flags: approval-comm-beta?
Attachment #8837390 - Flags: approval-comm-aurora?
Hmm, I landed that, and before landing it I looked at the patch and couldn't work out what it's doing. Now that you requested uplift, I have to understand what it's doing. Can you please give me some STR to show the non-working and the working behaviour.

"On a brand new profile, the Create a new account: row is not shown."

As hard as I looked at it, I couldn't work out what that means. Excuse the ignorance.
It is on the account central pane, which is shown when you select an account in the folder pane. In new profile (without accounts), the account central is shown automatically.

Without this patch you only see the row with items to create new accounts, saying Email, feeds, etc. but without indicating what they are for.

The patch exposes "Create a new account:" and "Accounts" labels above those buttons.
Comment on attachment 8837390 [details] [diff] [review]
accountcentral.patch

OK ;-)
Attachment #8837390 - Flags: approval-comm-beta?
Attachment #8837390 - Flags: approval-comm-beta+
Attachment #8837390 - Flags: approval-comm-aurora?
Attachment #8837390 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.