1339670 - Configure error: Could not determine cargo version from output: cargo-0.18.0-nightly (6f1b860 2017-02-11)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(Away)]

cargo-0.18.0-nightly (6f1b860 2017-02-11)

The "-" after "cargo" confuses the regex at http://searchfox.org/mozilla-central/rev/ac8a72f2d5204ced2004c93a9c193430c63a6a71/build/moz.configure/rust.configure#29

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1339670 - Use cargo --version --verbose output when available.

Fallback to regexp on older versions of cargo.

Review commit: https://reviewboard.mozilla.org/r/112532/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112532/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8837394 [details]
Bug 1339670 - Use cargo --version --verbose output when available.

https://reviewboard.mozilla.org/r/112532/#review113960

Sure, with some kind of change below for the comment.

::: build/moz.configure/rust.configure:26
(Diff revision 1)
>      # |cargo --version| doesn't have pleasant-to-parse output like rustc
>      # does. So we have to resort to regexes.

This comment now needs to be updated?

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8837394 [details]
Bug 1339670 - Use cargo --version --verbose output when available.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112532/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dda88ca630d
Use cargo --version --verbose output when available. r=froydnj

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8dda88ca630d