Closed Bug 1339670 Opened 5 years ago Closed 5 years ago

Configure error: Could not determine cargo version from output: cargo-0.18.0-nightly (6f1b860 2017-02-11)

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: away, Assigned: glandium)

References

Details

Attachments

(1 file)

cargo-0.18.0-nightly (6f1b860 2017-02-11)

The "-" after "cargo" confuses the regex at http://searchfox.org/mozilla-central/rev/ac8a72f2d5204ced2004c93a9c193430c63a6a71/build/moz.configure/rust.configure#29
Assignee: nobody → mh+mozilla
Comment on attachment 8837394 [details]
Bug 1339670 - Use cargo --version --verbose output when available.

https://reviewboard.mozilla.org/r/112532/#review113960

Sure, with some kind of change below for the comment.

::: build/moz.configure/rust.configure:26
(Diff revision 1)
>      # |cargo --version| doesn't have pleasant-to-parse output like rustc
>      # does. So we have to resort to regexes.

This comment now needs to be updated?
Attachment #8837394 - Flags: review?(nfroyd) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/8dda88ca630d
Use cargo --version --verbose output when available. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/8dda88ca630d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.