stylo: update glue to set transform-box as a StyleGeometryBox.

RESOLVED FIXED

Status

()

Core
CSS Parsing and Computation
P1
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: cjku, Assigned: cjku)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

4 months ago
Bug 1335876 does some refactoring of how computed transform-box values are stored. stylo glue side change is needed
(Assignee)

Comment 1

4 months ago
Hi Manish, heycam said I may ask help from you. Could you handle the stylo glue code for this change?
I changed type of mTransformBox from uint8_t to StyleGeometryBox(similar to the change in bug 	1336905) and stylo build break
Flags: needinfo?(manishearth)
(Assignee)

Updated

4 months ago
Depends on: 1340044
(Assignee)

Updated

4 months ago
No longer depends on: 1335876
I think the fix for this landed in a separate bug? I'm not sure now, sorry, missed this.
Flags: needinfo?(manishearth)
Is this still an issue?
Flags: needinfo?(cku)
Priority: -- → P3
(Assignee)

Comment 4

3 months ago
Yes, it still is. I will handle this one and bug 1340044, which is depend on this one.
Flags: needinfo?(cku)
Ok. P1, over to CJ.
Assignee: nobody → cku
Priority: P3 → P1
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

3 months ago
Attachment #8847948 - Flags: review?(cam)
Attachment #8847949 - Flags: review?(cam)

Comment 8

3 months ago
mozreview-review
Comment on attachment 8847948 [details]
Bug 1339674 - Part 1. Update glue to clip-path.

https://reviewboard.mozilla.org/r/120886/#review122838
Attachment #8847948 - Flags: review?(cam) → review+

Comment 9

3 months ago
mozreview-review
Comment on attachment 8847949 [details]
Bug 1339674 - Part 2. Update glue to transform-box.

https://reviewboard.mozilla.org/r/120888/#review122840
Attachment #8847949 - Flags: review?(cam) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Status: NEW → ASSIGNED
(Assignee)

Comment 12

3 months ago
Fixed by https://github.com/servo/servo/pull/16004
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.