1339757 - Last keyword is deleted when adding new keyword to bookmark, if there are more than 248 keywords defined

Status: RESOLVED INCOMPLETE

(Firefox :: Bookmarks & History, defect)

Description

[tero gusto]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170201180315

Steps to reproduce:

1. Add 248 keywords to different bookmarks
2. Add keyword number 249 to a bookmark
3. Go to the previous bookmark and see that the keyword has been removed


Actual results:

Keyword is deleted from a (seemingly random) bookmark.


Expected results:

A keyword for a bookmark is never deleted, when adding a keyword to a bookmark.

Comment 1

[Loic]

Could you share a bookmark archive with 248 bookmaks and keywords to import, please. It would help to test.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Can't reproduce the issue with the following script:

var bmsvc = Components.classes["@mozilla.org/browser/nav-bookmarks-service;1"]
                      .getService(Components.interfaces.nsINavBookmarksService);
var menuFolder = bmsvc.bookmarksMenuFolder; // Bookmarks menu folder
var newFolderId = bmsvc.createFolder(menuFolder, "Test", bmsvc.DEFAULT_INDEX);
var ios = Components.classes["@mozilla.org/network/io-service;1"]
                    .getService(Components.interfaces.nsIIOService);
for (var i = 1; i < 260; i++)
{
  var uri = ios.newURI(`https://sub${i}.example.com/`, null, null);
  var newBkmkId = bmsvc.insertBookmark(newFolderId, uri, bmsvc.DEFAULT_INDEX, "");
  bmsvc.setKeywordForBookmark(newBkmkId, `keyword${i}`)
}

Comment 3

[tero gusto]

@Loic: I am sorry, but I have since updated my bookmarks, so I now have only 40-50 keywords defined...

Comment 4

[Marco Bonardo [:mak]]

I don't think there's anything to do with the number of keywords, but a keyword can only point to a single uri. it's likely with so many keywords you may have tried to set an already existing keyword to a different uri, or changed uri for an existing keyword and that uri already had another keyword associated.

Also considered comment 2, this report unfortunately doesn't look actionable.

Comment 5

[tero gusto]

That's fine, at least there is a bug report now, if anyone else encounters this at some point in the future.