Wrong layout panel accordion header hover color with dark theme

VERIFIED FIXED in Firefox 54

Status

defect
P3
normal
VERIFIED FIXED
2 years ago
Last year

People

(Reporter: pbro, Assigned: jdescottes)

Tracking

(Blocks 1 bug)

unspecified
Firefox 54
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox54 verified)

Details

Attachments

(1 attachment)

STR:
- open the latest nightly
- set pref devtools.layoutview.enabled to true
- open the toolbox
- switch to the dark theme
- in the inspector, switch to the Layout sidebar tab
- hover over the "box model" and "grid" headers

==> The hover background color is white-ish, which looks a bit weird with the dark theme, and not consistent with the rest of the UI.

If you look at the debugger, it also has accordion widgets in its sidebar, but the hover color is different there (hover over the "breadkpoints" header for instance).
Blocks: dt-grid
Priority: -- → P3
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Flags: qe-verify+
Comment on attachment 8839963 [details]
Bug 1339783 - use theme-toolbar-hover for accordion header background on hover;

https://reviewboard.mozilla.org/r/114540/#review116180

::: devtools/client/themes/variables.css:21
(Diff revision 1)
>  
>  :root.theme-light {
>    --theme-body-background: white;
>    --theme-sidebar-background: white;
>    --theme-contrast-background: #e6b064;
> +  --theme-hover-background: #e6b064;

Looks like this isn't needed.
Attachment #8839963 - Flags: review?(gl) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb33fb4a86b6
use theme-toolbar-hover for accordion header background on hover;r=gl
Landed with the fix.
https://hg.mozilla.org/mozilla-central/rev/bb33fb4a86b6
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170301030202

Verified fixed using the latest Nightly 54.0a1 (2017-03-01) on Ubuntu 16.04, Mac OS X 10.11 and Windows 10 x64.
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.