1339783 - Wrong layout panel accordion header hover color with dark theme

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Patrick Brosset <:pbro>]

STR:
- open the latest nightly
- set pref devtools.layoutview.enabled to true
- open the toolbox
- switch to the dark theme
- in the inspector, switch to the Layout sidebar tab
- hover over the "box model" and "grid" headers

==> The hover background color is white-ish, which looks a bit weird with the dark theme, and not consistent with the rest of the UI.

If you look at the debugger, it also has accordion widgets in its sidebar, but the hover color is different there (hover over the "breadkpoints" header for instance).

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1339783 - use theme-toolbar-hover for accordion header background on hover;

Move toolbar only variable toolbar-tab-hover to variables.css and reuse it in
accordion.

Review commit: https://reviewboard.mozilla.org/r/114540/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/114540/

Comment 2

[Gabriel [:gl] (ΦωΦ)]

Comment on attachment 8839963 [details]
Bug 1339783 - use theme-toolbar-hover for accordion header background on hover;

https://reviewboard.mozilla.org/r/114540/#review116180

::: devtools/client/themes/variables.css:21
(Diff revision 1)
>  
>  :root.theme-light {
>    --theme-body-background: white;
>    --theme-sidebar-background: white;
>    --theme-contrast-background: #e6b064;
> +  --theme-hover-background: #e6b064;

Looks like this isn't needed.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb33fb4a86b6
use theme-toolbar-hover for accordion header background on hover;r=gl

Comment 4

[Gabriel [:gl] (ΦωΦ)]

Landed with the fix.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bb33fb4a86b6

Comment 6

[roxleitan]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170301030202

Verified fixed using the latest Nightly 54.0a1 (2017-03-01) on Ubuntu 16.04, Mac OS X 10.11 and Windows 10 x64.