Closed Bug 1339797 Opened 8 years ago Closed 8 years ago

Using "Select all" option in Text selection menu in a text box dismisses the menu

Categories

(Firefox for Android Graveyard :: Text Selection, defect)

Product:
Firefox for Android Graveyard
Component:
Text Selection
Version:
54 Branch
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(fennec+, firefox51 unaffected, firefox52+ fixed, firefox-esr52 fixed, firefox53+ verified, firefox54+ verified)

Status:
RESOLVED FIXED
Milestone:
Firefox 54
Tracking Flags:
Tracking Status
fennec + ---
firefox51 --- unaffected
firefox52 + fixed
firefox-esr52 --- fixed
firefox53 + verified
firefox54 + verified

People

(Reporter: kaarticsivaraam91196+bugzilla, Assigned: TYLin)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1339797 - Fix select-all events fired by touch incorrectly hide the carets.
59 bytes, text/x-review-board-request
mtseng
: review+
gchang
: approval-mozilla-aurora+
jcristau
: approval-mozilla-beta+
Details
The "Select all" option in the text selection menu dismissed the menu when it is used in a text input field. Steps to reproduce: 1. Type some text in a text input field 2. Select a portion of it 3. Tap the "Select all" option from the Text selection menu Expected results: All text in text field is selected and the Text selection menu remains for using other option such as Cut, Copy etc. Actual results: All text in text field is selected but the Text selection menu is dismissed. This troubles the user as he not able to immediately cut/copy the selected text or paste text to replace the selected text.
Still working fine on Release.
tracking-fennec: --- → ?
Has Regression Range: --- → no
Has STR: --- → yes
status-firefox51: --- → unaffected
status-firefox52: --- → ?
status-firefox53: --- → ?
Keywords: regression, regressionwindow-wanted
[Tracking Requested - why for this release]: Regression in Fx 52 Bug 1235513 seems like a good candidate.
Blocks: 1235513
Has Regression Range: no → yes
status-firefox52: ? → affected
status-firefox53: ? → affected
tracking-firefox52: --- → ?
tracking-firefox53: --- → ?
tracking-firefox54: --- → ?
Flags: needinfo?(bugmail)
Bug 1307252 is an even better one - verified by testing the relevant autoland builds.
Blocks: 1307252
No longer blocks: 1235513
Flags: needinfo?(bugmail) → needinfo?(tlin)
Tracking 52/53/54 for this user facing regression.
tracking-firefox52: ? → +
tracking-firefox53: ? → +
tracking-firefox54: ? → +
Thank you all for reporting this bug, and find the regression bug. I'll fix this.
Assignee: nobody → tlin
Status: NEW → ASSIGNED
Flags: needinfo?(tlin)
Comment on attachment 8838413 [details] Bug 1339797 - Fix select-all events fired by touch incorrectly hide the carets. https://reviewboard.mozilla.org/r/113338/#review114818
Attachment #8838413 - Flags: review?(mtseng) → review+
Pushed by tlin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fe7a3aa27666 Fix select-all events fired by touch incorrectly hide the carets. r=mtseng
https://hg.mozilla.org/mozilla-central/rev/fe7a3aa27666
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Please request Aurora/Beta approval on this when you get a chance.
Flags: needinfo?(tlin)
Comment on attachment 8838413 [details] Bug 1339797 - Fix select-all events fired by touch incorrectly hide the carets. Approval Request Comment [Feature/Bug causing the regression]: Bug 1307252. [User impact if declined]: If declined, after clicking "SELECT ALL" on the toolbar in a input field (like Google Search), the carets and toolbar will disappear. [Is this code covered by automated tests?]: No. [Has the fix been verified in Nightly?]: I've verified on Nightly (2017-02-18). [Needs manual test from QE? If yes, steps to reproduce]: It would be good to double check by QE. See comment 0 for the steps. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: Low. [Why is the change risky/not risky?]: Simple one line change, which affects only the select all logic. [String changes made/needed]: None.
Flags: needinfo?(tlin)
Attachment #8838413 - Flags: approval-mozilla-beta?
Attachment #8838413 - Flags: approval-mozilla-aurora?
Hi Brindusa, could you help find someone to verify if this issue was fixed as expected on a latest Nightly build? Thanks!
Flags: needinfo?(brindusa.tot)
Hi, Verified as fixed in latest Nightly build (2017-02-19); Device: Nexus 9 (Android 7.1). After clicking "SELECT ALL" on the toolbar in a input field, the carets and toolbar is still displayed.
status-firefox54: fixed → verified
Flags: needinfo?(brindusa.tot)
Comment on attachment 8838413 [details] Bug 1339797 - Fix select-all events fired by touch incorrectly hide the carets. Fix a UI issue and was verified. Aurora53+.
Attachment #8838413 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8838413 [details] Bug 1339797 - Fix select-all events fired by touch incorrectly hide the carets. let's get this regression fix in the next beta build.
Attachment #8838413 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
tracking-fennec: ? → +
Verified as fixed in build 53.0a2 (2017-02-22); Device: LG G4 (Android 6.0.1).
status-firefox53: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: