The "Select all" option in the text selection menu dismissed the menu when it is used in a text input field. Steps to reproduce: 1. Type some text in a text input field 2. Select a portion of it 3. Tap the "Select all" option from the Text selection menu Expected results: All text in text field is selected and the Text selection menu remains for using other option such as Cut, Copy etc. Actual results: All text in text field is selected but the Text selection menu is dismissed. This troubles the user as he not able to immediately cut/copy the selected text or paste text to replace the selected text.
Still working fine on Release.
tracking-fennec: --- → ?
Has Regression Range: --- → no
Has STR: --- → yes
status-firefox51: --- → unaffected
status-firefox52: --- → ?
status-firefox53: --- → ?
Keywords: regression, regressionwindow-wanted
Regression window: Last good build: 2016-10-06 First bad build: 2016-10-07 Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=777fb63db8de8d78b64b8141d1a998397275dd03&tochange=4b9944879c9a60a9aba4a744a7401bc38e0f39c4
[Tracking Requested - why for this release]: Regression in Fx 52 Bug 1235513 seems like a good candidate.
Has Regression Range: no → yes
status-firefox52: ? → affected
status-firefox53: ? → affected
tracking-firefox52: --- → ?
tracking-firefox53: --- → ?
tracking-firefox54: --- → ?
Bug 1307252 is an even better one - verified by testing the relevant autoland builds.
Tracking 52/53/54 for this user facing regression.
tracking-firefox52: ? → +
tracking-firefox53: ? → +
tracking-firefox54: ? → +
Thank you all for reporting this bug, and find the regression bug. I'll fix this.
Assignee: nobody → tlin
Status: NEW → ASSIGNED
Comment on attachment 8838413 [details] Bug 1339797 - Fix select-all events fired by touch incorrectly hide the carets. https://reviewboard.mozilla.org/r/113338/#review114818
Attachment #8838413 - Flags: review?(mtseng) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/fe7a3aa27666 Fix select-all events fired by touch incorrectly hide the carets. r=mtseng
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Please request Aurora/Beta approval on this when you get a chance.
Comment on attachment 8838413 [details] Bug 1339797 - Fix select-all events fired by touch incorrectly hide the carets. Approval Request Comment [Feature/Bug causing the regression]: Bug 1307252. [User impact if declined]: If declined, after clicking "SELECT ALL" on the toolbar in a input field (like Google Search), the carets and toolbar will disappear. [Is this code covered by automated tests?]: No. [Has the fix been verified in Nightly?]: I've verified on Nightly (2017-02-18). [Needs manual test from QE? If yes, steps to reproduce]: It would be good to double check by QE. See comment 0 for the steps. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: Low. [Why is the change risky/not risky?]: Simple one line change, which affects only the select all logic. [String changes made/needed]: None.
Hi Brindusa, could you help find someone to verify if this issue was fixed as expected on a latest Nightly build? Thanks!
Hi, Verified as fixed in latest Nightly build (2017-02-19); Device: Nexus 9 (Android 7.1). After clicking "SELECT ALL" on the toolbar in a input field, the carets and toolbar is still displayed.
status-firefox54: fixed → verified
Comment on attachment 8838413 [details] Bug 1339797 - Fix select-all events fired by touch incorrectly hide the carets. Fix a UI issue and was verified. Aurora53+.
Attachment #8838413 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
status-firefox53: affected → fixed
Comment on attachment 8838413 [details] Bug 1339797 - Fix select-all events fired by touch incorrectly hide the carets. let's get this regression fix in the next beta build.
Attachment #8838413 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-firefox52: affected → fixed
status-firefox-esr52: --- → fixed
Verified as fixed in build 53.0a2 (2017-02-22); Device: LG G4 (Android 6.0.1).
status-firefox53: fixed → verified
You need to log in before you can comment on or make changes to this bug.