1339817 - Enable Intl.PluralRules tests from test262

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, defect)

Description

[André Bargull [:anba]]

This feature requires some small changes to the test262 import script.

Comment 1

[André Bargull [:anba]]

Attachment: bug1339817-part1-local-includes-feature.patch

With this change it's possible to specify additional includes for specific test262 subdirectories. This will be used in part 2 to add the addIntlExtras() shell helper for tests in test262/intl402/PluralRules.

I've also removed the fallback code for "async" and "negative" attributes, because all test262 files now have the correct meta-data. And I've enabled the error output for monkey-yaml parse errors, so we don't silently skip files with bad meta-data. There are some files which currently can't be parsed by monkey-yaml, this will be fixed by https://github.com/tc39/test262/pull/862.

Comment 2

[André Bargull [:anba]]

Attachment: bug1339817-part2-enable-pluralrules-tests.patch

Added preprocessing for test262/intl402/PluralRules to test262-update.py and regenerated the test262 checkout (with `python test262-update.py --revision 8a0563dd5eb9c6ee1df8a17cf8f626c35fa56a46` to avoid updating to latest master).

Comment 3

[Shu-yu Guo [:shu]]

Comment on attachment 8837641 [details] [diff] [review]
bug1339817-part1-local-includes-feature.patch

Review of attachment 8837641 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/test262-update.py
@@ +203,5 @@
> +    # when the error is issued (runtime error or early parse error). We're
> +    # currently ignoring this additional meta-data.
> +    # testRec["negative"] == {type=<error name>, phase=early|runtime}
> +    isNegative = "negative" in testRec
> +    assert "negative" not in testRec or type(testRec["negative"]) == dict

assert not isNegative

Comment 4

[Shu-yu Guo [:shu]]

Comment on attachment 8837646 [details] [diff] [review]
bug1339817-part2-enable-pluralrules-tests.patch

Review of attachment 8837646 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 5

[Shu-yu Guo [:shu]]

+:gandalf

Comment 6

[André Bargull [:anba]]

Attachment: bug1339817-part1-local-includes-feature.patch

Update part 1 per review comments, carrying r+ from shu.

Comment 7

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e8264f2931eeaa1026f3da698e6265127e3b225

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa58978bd709
Part 1: Allow to specify additional includes for test262 tests. r=shu
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6603d52cd90
Part 2: Enable Intl.PluralRules tests from test262. r=shu

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fa58978bd709
https://hg.mozilla.org/mozilla-central/rev/f6603d52cd90