1339824 - Move metadata storage to a separate DB in preparation for syncing

Status: RESOLVED FIXED

(Firefox for iOS :: Data Storage, defect, P1)

Description

[Emily Toop (:fluffyemily)]

Currently metadata is stored in a separate table inside the main Firefox DB. To bring the FxiOS implementation in line with desktop, the metadata storage should be moved to a separate DB and ATTACHed to the existing DB during querying. This is so that we can sync metadata at a later date more easily.

Comment 1

[Emily Toop (:fluffyemily)]

Attachment: Pull request

Comment 2

[Stephan Leroux [:sleroux]]

Attachment: Github PR https://github.com/mozilla-mobile/firefox-ios/pull/2561

Comment 3

[Stephan Leroux [:sleroux]]

Revert due to regressions on master for now.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request v2

Steph, I left the PR as 2 commits. The first one is the original patch that we backed out. The second commit contains my changes to the schema initialization so we don't crash if the DB is deleted after a connection is established (which technically *shouldn't* ever happen). It also fixes the way we reset the profile in the XCUITests so that the aforementioned DB deletion doesn't happen after we've already connected to it.

Comment 5

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/eadaa0053781e90a51c7042ef09f042a565dcb9f