Toolbar customization broken in Firefox 51.0.1

RESOLVED WONTFIX

Status

Tech Evangelism
Add-ons
--
major
RESOLVED WONTFIX
a year ago
a month ago

People

(Reporter: Jeffery Small, Unassigned)

Tracking

Firefox 51
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

a year ago
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170201174907

Steps to reproduce:

Open customization tab and attempt to modify toolbar.


Actual results:

Drag/drop broken.  No new items can be placed on toolbar (e.g., separator).  No items can be removed from toolbar.  No existing items can be relocated on toolbar.


Expected results:

All operations should work.  They do work for Firefox on a Windows 10 platform, but are not working on multiple instances of the desktop browser on my Xubuntu 16.10 system.
(Reporter)

Updated

a year ago
Severity: normal → major
OS: Unspecified → Linux
Hardware: Unspecified → x86_64

Updated

a year ago
Component: Untriaged → Toolbars and Customization

Comment 1

a year ago
Does it work if you restart in safe mode (Help > Restart with add-ons disabled) ? Do errors appear in the browser console when you try to drag/drop items and it doesn't work? (on Linux, you can open the browser console with ctrl-shift-j)
Flags: needinfo?(jeff)
(Reporter)

Comment 2

a year ago
With console enabled, in safe mode the customization feature works and there are no messages entering or exiting customization mode.

In regular mode, the following message is logged when entering customization:

    S4E Calling beforeCustomization: {hex string}

When trying to drag an element on the toolbar the following error is generated:

    TypeError: target is null

However, this message is not generated again when trying to drag the same element or perform any other customization operation.  Upon exiting customization, the following message is generated:

    S4E Calling updateWindow: {hex string}

I tried disabling a number of the recently added/updated add-ons, including those with icons on the toolbar.  I restarted Firefox, but there was no improvement.

Comment 3

a year ago
It looks like those messages come from status-4-evar. Does disabling it help? Otherwise, given things work in safe mode, I expect the problem is still related to one of your add-ons. You'd have to bisect the add-ons (enable half, disable the other half, restart, check if you can reproduce, then drill down the broken/working halves, and repeat) to work out which add-on(s) are responsible.
(Reporter)

Comment 4

a year ago
I first disabled Status-4-Evar and this had no effect.  I then went through blocks of add-ons disabling them, restarting Firefox and testing customization.  I finally disabled every add-on and still customization would not work!

One other thing I can report is that you also cannot move things between the Additional Tools area and the pull-down reservoir on right, and every time you touch something in the reservoir, the tools there get all jumbled up and most of them disappear.  They are there again when you exit and re-access the customization tab.

Comment 5

a year ago
(In reply to Jeffery Small from comment #4)
> I first disabled Status-4-Evar and this had no effect.  I then went through
> blocks of add-ons disabling them, restarting Firefox and testing
> customization.  I finally disabled every add-on and still customization
> would not work!

And at that point, do you get browser console messages?

This is pretty confusing because you said earlier that in safe mode things did work and there were no messages. Safe mode does change other things (like graphics hardware acceleration) besides add-ons, but I don't see how any of them would influence whether customization mode works. So I don't understand how things are busted when all your add-ons are disabled and working in safe mode.

When add-ons *are* enabled and you get the target is null error message, is there a source link next to it, and/or maybe a little expander arrow on its left, that contains a stack trace?

Can you attach the raw data (use the 'copy raw data' button) from about:supports ?
(Reporter)

Comment 6

a year ago
I discovered the actual problem.  It's not the add-ons, its the Nautipolis 3.10.1 Theme that is the problem.  Safe-Mode also disables the theme and that's why customization worked.  If I manually enable the default theme then customization works with all add-ons enabled.  Re-enable Nautipolis and it breaks!

Comment 7

a year ago
(In reply to Jeffery Small from comment #6)
> I discovered the actual problem.  It's not the add-ons, its the Nautipolis
> 3.10.1 Theme that is the problem.  Safe-Mode also disables the theme and
> that's why customization worked.  If I manually enable the default theme
> then customization works with all add-ons enabled.  Re-enable Nautipolis and
> it breaks!

Ah, right, themes are basically add-ons too (but I agree this is confusing...).

I suspect you will need to take this up with the theme author... they can hide/show/alter any of our elements and even to some degree how they function, and depending on what they do code may not be able to deal with that. We're working on a better separation between themes and the rest of the browser so that it's easier to create appealing themes that don't mess up how the browser works, but until that's here, I suspect that's your best bet.

It's still possible this is a bug in Firefox, but for that we'd need the theme author to have a look, I'm afraid... Andreas, do we have contact details for the folks behind Nautipolis?
Component: Toolbars and Customization → Add-ons
Flags: needinfo?(awagner)
Product: Firefox → Tech Evangelism
Version: 51 Branch → Firefox 51
(Reporter)

Comment 8

a year ago
The author doesn't seem to provide any contact info on the theme or author page.  Hopefully you can contact him internally and point him to this bug report.

Thanks for the help in getting me to this point.  I'll either disable the theme when I want to customize, or will search out a new theme.

https://addons.mozilla.org/en-US/firefox/addon/nautipolis-for-firefox/
Added designer to CC.
Flags: needinfo?(awagner)
Thanks, Jorge.
(Reporter)

Comment 11

a year ago
Related to this, the Nautipolis theme is also stopping the Google User pop-up (click on the user image in the upper-right corner of any Google page) from displaying.  it is seriously broken in Firefox 51 and will have to be abandoned if the developer doesn't address these problems immediately.

Comment 12

a year ago
(In reply to Jeffery Small from comment #11)
> Related to this, the Nautipolis theme is also stopping the Google User
> pop-up (click on the user image in the upper-right corner of any Google
> page) from displaying.  it is seriously broken in Firefox 51 and will have
> to be abandoned if the developer doesn't address these problems immediately.

This is working for me in Firefox 45 - 55 (current nightlies).
Probably related to another extension or so.

Comment 13

a year ago
Anyway, try with version 3.10.2. May be that one works for you?
(Reporter)

Comment 14

a year ago
Alfred, I would be happy to try out 3.10.2.  I just went to the Mozilla Extension site:

https://addons.mozilla.org/en-US/firefox/addon/nautipolis-for-firefox/?src=search

and reinstalled the current Nautipolis theme, but this seems to still be 3.10.1.  Where do I go to get 3.10.2?

Thanks.
Flags: needinfo?(jeff)
Mass-closing bugs that relate to legacy versions of add-ons or are otherwise no longer worth tracking. Please comment if you think this bug should be reopened.

Sorry for the bugspam. Made you look, though!
Status: UNCONFIRMED → RESOLVED
Last Resolved: a month ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.